add new rule for python configuration validation #39142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
MaryGao
reviewed
Dec 10, 2025
| } | ||
| } | ||
|
|
||
| export class TspConfigPythonNamespaceMatchesEmitterOutputDirSubRule extends TspconfigSubRuleBase { |
Member
There was a problem hiding this comment.
Is this rule to validate the namespace is matching with last segment of emitter-output-dir?
MaryGao
reviewed
Dec 10, 2025
| return { success: true }; | ||
| } | ||
|
|
||
| private resolveLastPathSegment( |
Member
There was a problem hiding this comment.
@skywing918 Can we share a helper to get the last segment of emitter-output-dir?
I think we need to share this logic and also in that logic to fix our existing bug:#38964.
MaryGao
requested changes
Dec 10, 2025
Member
MaryGao
left a comment
MaryGao
left a comment
There was a problem hiding this comment.
As offline discussed, @skywing918 pls have a pr to prepare the helper first so that in this pr we could leverage the same helper and no need to duplicate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For python, inconsistency between
emitter-output-dirandnamespacewill cause unexpected error (e.g. here) so we need add a new rule for python.