Harden HTTP proxy header handling#440
Merged
Merged
Conversation
Block hop-by-hop response headers from being forwarded through the HTTP proxy and handle invalid x-ms-client-principal payloads without failing the invocation. Co-authored-by: Dobby <dobby@microsoft.com>
swapnil-nagar
requested changes
May 19, 2026
Allow Content-Length through the HTTP proxy while continuing to block hop-by-hop headers. Also strip response headers named by the Connection header so connection-specific fields do not cross the proxy boundary. Co-authored-by: Dobby <dobby@microsoft.com>
swapnil-nagar
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-ms-client-principalpayloads without failing the invocationNotes
F4 (
ensureErrorTypeobject serialization) is intentionally not changed in this PR. That area needs a separate design discussion because the safer fix likely requires sanitizer behavior aligned with azure-functions-host and azure-functions-nodejs-worker, not just using an object'smessageproperty.Validation
npm test(375 passed)npm run lint