Skip to content

{Batch} BULK Fix broken link 2 #33047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
v-thepet wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

{Batch} BULK Fix broken link 2 #33047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/batch/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ def load_arguments(self, _):
'since the specified time.')

with self.argument_context('batch pool create') as c:
c.argument('json_file', help='The file containing pool create properties parameter specification in JSON(formatted to match REST API request body). If this parameter is specified, all \'Pool Create Properties Parameter Arguments\' are ignored. See https://learn.microsoft.com/rest/api/batchservice/pool/add?tabs=HTTP#request-body')
c.argument('json_file', help='The file containing pool create properties parameter specification in JSON(formatted to match REST API request body). If this parameter is specified, all \'Pool Create Properties Parameter Arguments\' are ignored. See https://learn.microsoft.com/rest/api/batchservice/pools/create-pool?tabs=HTTP#request-body')
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

batch pool create defines json_file without type=file_type, validator=validate_json_file, or FilesCompleter(), unlike the other json_file arguments in this module (e.g., pool reset/task create). This means the create path won't validate file existence / JSON validity consistently and loses file path completion; please align the argument definition with the others.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@v-thepet v-thepet Mar 25, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment makes no sense. The correction is in a link to a documentation web page in the "Help" section that explains the --json-file parameter. It's not defining a json file itself. The previous link to the documentation web page https://learn.microsoft.com/rest/api/batchservice/pool/add does not work because the batchservice/pool API has changed. The new link https://learn.microsoft.com/rest/api/batchservice/pools/create-pool works. Although adding the type=file_type might not hurt anything, it is not there in the existing file and I don't feel comfortable adding it because the only change in this PR should be to fix the broken doc link.

c.argument('enable_accelerated_networking', arg_type=get_three_state_flag(), options_list=['--accelerated-networking'], arg_group="Pool: Network Configuration",
help='Whether this pool should enable accelerated networking. Accelerated networking enables single root I/O virtualization (SR-IOV) to a VM, which may lead to improved networking performance. For more details, see: https://learn.microsoft.com/azure/virtual-network/accelerated-networking-overview. Set true to enable.')
c.argument('caching',
Expand Down
Loading