Skip to content

{Batchai} Migrate vm size completer of calling Compute module to aaz-based implementation #32948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
william051200 wants to merge 4 commits into
base: dev
Choose a base branch
from
+20 −17
Open

{Batchai} Migrate vm size completer of calling Compute module to aaz-based implementation #32948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6365963
Migrate batchai module
william051200 Mar 10, 2026
275b9aa
Update vm list size api
william051200 Mar 13, 2026
12a8d44
Update test case recording
william051200 Mar 13, 2026
b1a9b8a
Merge remote-tracking branch 'origin/dev' into batchai-vm-migration
william051200 Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/azure-cli/azure/cli/command_modules/batchai/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@


def get_vm_sizes(cli_ctx, location):
from azure.cli.core.profiles import ResourceType
from azure.cli.core.commands.client_factory import get_mgmt_service_client
client_factory = get_mgmt_service_client(cli_ctx, ResourceType.MGMT_COMPUTE)
return list(client_factory.virtual_machine_sizes.list(location))
from ..vm.operations.vm import VMListSizes
return VMListSizes(cli_ctx=cli_ctx)(command_args={
'location': location
})


@Completer
Expand All @@ -23,7 +23,7 @@ def get_vm_size_completion_list(cmd, prefix, namespace, **kwargs): # pylint: di
except AttributeError:
location = get_one_of_subscription_locations(cmd.cli_ctx)
result = get_vm_sizes(cmd.cli_ctx, location)
return [r.name for r in result]
return [r.get('name') for r in result]


# pylint: disable=line-too-long, too-many-statements
Expand Down
9 changes: 6 additions & 3 deletions src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/_list_sizes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ class ListSizes(AAZCommand):
"""

_aaz_info = {
"version": "2022-11-01",
"version": "2024-11-01",
"resources": [
["mgmt-plane", "/subscriptions/{}/providers/microsoft.compute/locations/{}/vmsizes", "2022-11-01"],
["mgmt-plane", "/subscriptions/{}/providers/microsoft.compute/locations/{}/vmsizes", "2024-11-01"],
]
}

Expand Down Expand Up @@ -111,7 +111,7 @@ def url_parameters(self):
def query_parameters(self):
parameters = {
**self.serialize_query_param(
"api-version", "2022-11-01",
"api-version", "2024-11-01",
required=True,
),
}
Expand Down Expand Up @@ -144,6 +144,9 @@ def _build_schema_on_200(cls):
cls._schema_on_200 = AAZObjectType()

_schema_on_200 = cls._schema_on_200
_schema_on_200.next_link = AAZStrType(
serialized_name="nextLink",
)
_schema_on_200.value = AAZListType()

value = cls._schema_on_200.value
Expand Down
6 changes: 3 additions & 3 deletions ...ure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_dedicated_host_e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,7 @@ interactions:
- AZURECLI/2.47.0 azsdk-python-azure-mgmt-compute/29.1.0 Python/3.10.11 (Linux-5.15.0-1036-azure-x86_64-with-glibc2.31)
VSTS_7b238909-6802-4b65-b90d-184bca47f458_build_220_0
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westeurope/vmSizes?api-version=2022-11-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westeurope/vmSizes?api-version=2024-11-01
response:
body:
string: "{\r\n \"value\": [\r\n {\r\n \"name\": \"Standard_B1ls\",\r\n
Expand Down Expand Up @@ -4639,7 +4639,7 @@ interactions:
- AZURECLI/2.47.0 azsdk-python-azure-mgmt-compute/29.1.0 Python/3.10.11 (Linux-5.15.0-1036-azure-x86_64-with-glibc2.31)
VSTS_7b238909-6802-4b65-b90d-184bca47f458_build_220_0
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/eastus/vmSizes?api-version=2022-11-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/eastus/vmSizes?api-version=2024-11-01
response:
body:
string: "{\r\n \"value\": [\r\n {\r\n \"name\": \"Standard_B1ls\",\r\n
Expand Down Expand Up @@ -7743,7 +7743,7 @@ interactions:
- AZURECLI/2.47.0 azsdk-python-azure-mgmt-compute/29.1.0 Python/3.10.11 (Linux-5.15.0-1036-azure-x86_64-with-glibc2.31)
VSTS_7b238909-6802-4b65-b90d-184bca47f458_build_220_0
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/eastus/vmSizes?api-version=2022-11-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/eastus/vmSizes?api-version=2024-11-01
response:
body:
string: "{\r\n \"value\": [\r\n {\r\n \"name\": \"Standard_B1ls\",\r\n
Expand Down
2 changes: 1 addition & 1 deletion .../azure/cli/command_modules/vm/tests/latest/recordings/test_vm_accelerated_networking.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1752,7 +1752,7 @@ interactions:
User-Agent:
- AZURECLI/2.71.0 azsdk-python-core/1.31.0 Python/3.10.11 (Windows-10-10.0.26100-SP0)
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/vmSizes?api-version=2022-11-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/vmSizes?api-version=2024-11-01
response:
body:
string: "{\r\n \"value\": [\r\n {\r\n \"name\": \"Standard_B1ls\",\r\n
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_size_list.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ interactions:
User-Agent:
- AZURECLI/2.68.0 azsdk-python-core/1.31.0 Python/3.11.9 (Windows-10-10.0.26100-SP0)
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/vmSizes?api-version=2022-11-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/vmSizes?api-version=2024-11-01
response:
body:
string: "{\r\n \"value\": [\r\n {\r\n \"name\": \"Standard_B1ls\",\r\n
Expand Down
2 changes: 1 addition & 1 deletion ...ommand_modules/vm/tests/latest/recordings/test_vm_update_ephemeral_os_disk_placement.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1705,7 +1705,7 @@ interactions:
User-Agent:
- AZURECLI/2.71.0 azsdk-python-core/1.31.0 Python/3.10.11 (Windows-10-10.0.26100-SP0)
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/vmSizes?api-version=2022-11-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/vmSizes?api-version=2024-11-01
response:
body:
string: "{\r\n \"value\": [\r\n {\r\n \"name\": \"Standard_B1ls\",\r\n
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_update_size.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1705,7 +1705,7 @@ interactions:
User-Agent:
- AZURECLI/2.71.0 azsdk-python-core/1.31.0 Python/3.10.11 (Windows-10-10.0.26100-SP0)
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/vmSizes?api-version=2022-11-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/vmSizes?api-version=2024-11-01
response:
body:
string: "{\r\n \"value\": [\r\n {\r\n \"name\": \"Standard_B1ls\",\r\n
Expand Down
2 changes: 1 addition & 1 deletion ...mand_modules/vm/tests/latest/recordings/test_vmss_create_ephemeral_os_disk_placement.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,7 @@ interactions:
User-Agent:
- AZURECLI/2.63.0 azsdk-python-core/1.28.0 Python/3.10.11 (Windows-10-10.0.22631-SP0)
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/vmSizes?api-version=2022-11-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/vmSizes?api-version=2024-11-01
response:
body:
string: "{\r\n \"value\": [\r\n {\r\n \"name\": \"Standard_B1ls\",\r\
Expand Down
2 changes: 1 addition & 1 deletion ...re-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vmss_create_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1868,7 +1868,7 @@ interactions:
User-Agent:
- AZURECLI/2.63.0 azsdk-python-core/1.28.0 Python/3.10.11 (Windows-10-10.0.22631-SP0)
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/vmSizes?api-version=2022-11-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/vmSizes?api-version=2024-11-01
response:
body:
string: "{\r\n \"value\": [\r\n {\r\n \"name\": \"Standard_B1ls\",\r\
Expand Down
Loading