Skip to content

[containerapp] az containerapp env workload-profile add Simplify wp creation with default profile name #32713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jepetty wants to merge 3 commits into
base: dev
Choose a base branch
from
+11,343 −3
Open

[containerapp] az containerapp env workload-profile add Simplify wp creation with default profile name #32713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f0ce02
Simplify API invocation for flex workload-profiles
jepetty Jan 27, 2026
aea38b2
Fix failing tests
jepetty Jan 28, 2026
cb4e6e9
Update so all workload profile types have a default name
jepetty Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/azure-cli/azure/cli/command_modules/containerapp/containerapp_env_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,10 +365,12 @@ def set_up_workload_profiles(self, r):
workload_profile_name = self.get_argument_workload_profile_name()
workload_profile_type = self.get_argument_workload_profile_type()

workload_profile_name = workload_profile_type if workload_profile_name is None else workload_profile_name

if workload_profile_name:
if "workloadProfiles" not in r["properties"] or not r["properties"]["workloadProfiles"]:
raise ValidationError(
"This environment does not allow for workload profiles. Can create a compatible environment with 'az containerapp env create --enable-workload-profiles'")
"This environment does not allow for workload profiles. You can create a compatible environment with 'az containerapp env create --enable-workload-profiles'")

if workload_profile_type:
workload_profile_type = workload_profile_type.upper()
Expand Down
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/containerapp/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5026,7 +5026,7 @@ def set_workload_profile(cmd, resource_group_name, env_name, workload_profile_na
return update_managed_environment(cmd, env_name, resource_group_name, workload_profile_type=workload_profile_type, workload_profile_name=workload_profile_name, min_nodes=min_nodes, max_nodes=max_nodes)


def add_workload_profile(cmd, resource_group_name, env_name, workload_profile_name, workload_profile_type=None, min_nodes=None, max_nodes=None):
def add_workload_profile(cmd, resource_group_name, env_name, workload_profile_name=None, workload_profile_type=None, min_nodes=None, max_nodes=None):
r = None
try:
r = ManagedEnvironmentClient.show(cmd=cmd, resource_group_name=resource_group_name, name=env_name)
Expand All @@ -5041,7 +5041,7 @@ def add_workload_profile(cmd, resource_group_name, env_name, workload_profile_na

workload_profiles_lower = [p["name"].lower() for p in workload_profiles]

if workload_profile_name.lower() in workload_profiles_lower:
if workload_profile_name and workload_profile_name.lower() in workload_profiles_lower:
raise ValidationError(f"Cannot add workload profile with name {workload_profile_name} because it already exists in this environment")

return update_managed_environment(cmd, env_name, resource_group_name, workload_profile_type=workload_profile_type, workload_profile_name=workload_profile_name, min_nodes=min_nodes, max_nodes=max_nodes)
Expand Down
Loading
Loading