[Storage] az storage account task-assignment create: Support MockRun as new triggerType#9898
Open
calvinhzy wants to merge 3 commits into
Open
[Storage] az storage account task-assignment create: Support MockRun as new triggerType#9898calvinhzy wants to merge 3 commits into
az storage account task-assignment create: Support MockRun as new triggerType#9898calvinhzy wants to merge 3 commits into
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Collaborator
|
Storage |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the storage-preview extension’s Storage Task Assignment commands to align with a newer Storage ARM API version and adds support for the new MockRun trigger type on az storage account task-assignment create/update.
Changes:
- Add
MockRunto the allowed trigger types for Storage Task Assignments and extend scenario coverage. - Bump Storage Task Assignment AAZ command generation to API version
2025-08-01(including schema/error-format updates and systemData). - Update extension version/metadata and refresh a test recording to match the newer API version.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/storage-preview/setup.py | Bumps the extension version to 1.0.0b8. |
| src/storage-preview/HISTORY.rst | Adds release notes entry for MockRun support. |
| src/storage-preview/azext_storage_preview/tests/latest/test_storage_account_scenarios.py | Extends task-assignment scenario test to create a MockRun assignment and adjusts expectations. |
| src/storage-preview/azext_storage_preview/tests/latest/recordings/test_storage_file_trailing_dot_scenario.yaml | Updates a recorded request to use the newer Storage ARM API version. |
| src/storage-preview/azext_storage_preview/azext_metadata.json | Raises minimum CLI core version to 2.75.0. |
| src/storage-preview/azext_storage_preview/aaz/latest/storage/account/task_assignment/_create.py | Adds MockRun enum option; updates API version/schema; request/arg schema adjustments. |
| src/storage-preview/azext_storage_preview/aaz/latest/storage/account/task_assignment/_update.py | Adds MockRun enum option; updates API version/schema and date-time formatting. |
| src/storage-preview/azext_storage_preview/aaz/latest/storage/account/task_assignment/_show.py | Updates API version/schema and name pattern. |
| src/storage-preview/azext_storage_preview/aaz/latest/storage/account/task_assignment/_list.py | Updates API version/schema; adjusts list query paging parameter usage. |
| src/storage-preview/azext_storage_preview/aaz/latest/storage/account/task_assignment/_list_report.py | Updates API version/schema and name pattern. |
| src/storage-preview/azext_storage_preview/aaz/latest/storage/account/task_assignment/_delete.py | Updates API version/name pattern; adjusts LRO final-state handling. |
| src/storage-preview/azext_storage_preview/aaz/latest/storage/account/task_assignment/_wait.py | Updates API version/schema and name pattern. |
|
|
||
| 1.0.0b8 | ||
| +++++++ | ||
| * `az storage account task-assignment`: Add `MockRun` to as a triggerType |
Comment on lines
75
to
79
| _args_schema.description = AAZStrArg( | ||
| options=["--description"], | ||
| arg_group="Properties", | ||
| help="Text that describes the purpose of the storage task assignment", | ||
| required=True, | ||
| ) |
| @@ -63,7 +63,7 @@ | |||
| help="The name of the storage task assignment within the specified resource group. Storage task assignment names must be between 3 and 24 characters in length and use numbers and lower-case letters only.", | |||
| id_part="child_name_1", | ||
| fmt=AAZStrArgFormat( | ||
| pattern="^[a-z0-9]{3,24}$", | ||
| pattern="^[a-z][a-z0-9]{2,23}$", |
| @@ -63,7 +63,7 @@ def _build_arguments_schema(cls, *args, **kwargs): | |||
| help="The name of the storage task assignment within the specified resource group. Storage task assignment names must be between 3 and 24 characters in length and use numbers and lower-case letters only.", | |||
| id_part="child_name_1", | ||
| fmt=AAZStrArgFormat( | ||
| pattern="^[a-z0-9]{3,24}$", | ||
| pattern="^[a-z][a-z0-9]{2,23}$", |
| id_part="child_name_1", | ||
| fmt=AAZStrArgFormat( | ||
| pattern="^[a-z0-9]{3,24}$", | ||
| pattern="^[a-z][a-z0-9]{2,23}$", |
| id_part="child_name_1", | ||
| fmt=AAZStrArgFormat( | ||
| pattern="^[a-z0-9]{3,24}$", | ||
| pattern="^[a-z][a-z0-9]{2,23}$", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
aaz Azure/aaz#1016
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.