[aks-preview] Add --enable-backup to az aks create and az aks update#9897
Draft
anshulahuja98 wants to merge 6 commits into
Draft
[aks-preview] Add --enable-backup to az aks create and az aks update#9897anshulahuja98 wants to merge 6 commits into
anshulahuja98 wants to merge 6 commits into
Conversation
Adds three new arguments to both 'az aks create' and 'az aks update' that orchestrate the same flow as 'az dataprotection enable-backup trigger':
--enable-backup
--backup-strategy {Week|Month|DisasterRecovery|Custom}
--backup-configuration-file
The backup orchestration (vault, policy, storage account, k8s extension install, trusted access, role assignments, backup instance creation) is delegated to the 'dataprotection' CLI extension via a thin shim (aks_backup.py) that imports the helper lazily. If the dataprotection extension is not installed, an actionable error is raised.
Wired into both create and update decorators via the postprocessing_after_mc_created path so backup runs only after the cluster mutation succeeds.
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter backup_configuration_file |
||
| aks create | cmd aks create added parameter backup_strategy |
||
| aks create | cmd aks create added parameter enable_backup |
||
| aks update | cmd aks update added parameter backup_configuration_file |
||
| aks update | cmd aks update added parameter backup_strategy |
||
| aks update | cmd aks update added parameter enable_backup |
|
Hi @anshulahuja98, |
microsoft-github-policy-service
Bot
requested review from
FumingZhang,
calvinhzy,
evelyn-ys,
yanzhudd,
yonzhan and
zhoxing-ms
Collaborator
|
aks |
added 2 commits
May 25, 2026 15:34
- Rename --backup-configuration-file to --backup-configuration (drops the misleading -file suffix; the validator accepts both @file.json and inline JSON). Also resolves option_length_too_long (HIGH). - Silence too-many-boolean-expressions in the update decorator's check_is_postprocessing_required, matching the existing pylint-disable already used in the create decorator's equivalent block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create/az aks updateAdds three new arguments to both commands that orchestrate the same flow as
az dataprotection enable-backup trigger:The backup orchestration (resource group, storage account, blob container, k8s extension install, backup vault, backup policy, trusted access role binding, RBAC role assignments, backup instance) is delegated to the existing helper in the
dataprotectionCLI extension. The aks-preview side is a thin shim that loads the dataprotection extension lazily, raises an actionable error when it is not installed, and derives the AKS datasource ARM id from-g/-n. The call is wired into the create and update decorators'postprocessing_after_mc_createdpath so backup is only configured after the cluster mutation succeeds.Companion to the merged dataprotection-side change: #9701 — Enable Backup Command for AKS in dataprotection CLI (which added
az dataprotection enable-backup trigger; this PR surfaces the same flow as a flag onaz aks create/az aks update).General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.