Managed Network Fabric CLI: enable bootstrap interface, bootstrap device, and other actions for existing command groups#9731
Managed Network Fabric CLI: enable bootstrap interface, bootstrap device, and other actions for existing command groups#9731idanielsteven wants to merge 21 commits intoAzure:mainfrom
Conversation
…ice, and other actions for existing command groups.
❌Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
This PR updates the managednetworkfabric Azure CLI extension to re-enable and add AAZ-generated command implementations (and scenario tests) for bootstrap device/interface and certificate resync/rotation operations, along with a version bump and changelog entry.
Changes:
- Bump extension version to 9.1.0 and add 9.1.0 release notes.
- Add AAZ command implementations for
fabric rotate-certificate,fabric resync-certificate,device resync-certificate, andbootstrapdevice/bootstrapinterface(list/show/wait). - Re-enable/activate scenario tests for the above commands and add a new recording for bootstrapinterface.
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/managednetworkfabric/setup.py | Bumps extension version to 9.1.0. |
| src/managednetworkfabric/HISTORY.rst | Adds 9.1.0 changelog entry. |
| src/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_nf_rotate_certificate.py | Enables scenario test for fabric rotate-certificate. |
| src/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_nf_resync_certificate.py | Enables scenario test for fabric resync-certificate. |
| src/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_device_resync_certificate.py | Enables scenario test for device resync-certificate. |
| src/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_bootstrapinterface.py | Enables scenario test for bootstrapinterface show/list. |
| src/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_bootstrapdevice.py | Enables scenario test for bootstrapdevice show/list. |
| src/managednetworkfabric/azext_managednetworkfabric/tests/latest/recordings/test_GA_bootstrapinterface_scenario1.yaml | Adds playback recording for bootstrapinterface scenario. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_rotate_certificate.py | Adds AAZ command for networkfabric fabric rotate-certificate. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_resync_certificate.py | Adds AAZ command for networkfabric fabric resync-certificate. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/fabric/init.py | Exposes new fabric certificate commands via imports. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/device/_resync_certificate.py | Adds AAZ command for networkfabric device resync-certificate. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/device/init.py | Exposes new device certificate command via import. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapinterface/__cmd_group.py | Adds AAZ command group networkfabric bootstrapinterface. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapinterface/init.py | Exposes bootstrapinterface commands via imports. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapinterface/_list.py | Adds networkfabric bootstrapinterface list. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapinterface/_show.py | Adds networkfabric bootstrapinterface show. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapinterface/_wait.py | Adds networkfabric bootstrapinterface wait. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapdevice/__cmd_group.py | Adds AAZ command group networkfabric bootstrapdevice. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapdevice/init.py | Exposes bootstrapdevice commands via imports. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapdevice/_list.py | Adds networkfabric bootstrapdevice list. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapdevice/_show.py | Adds networkfabric bootstrapdevice show. |
| src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapdevice/_wait.py | Adds networkfabric bootstrapdevice wait. |
src/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_nf_resync_certificate.py
Outdated
Show resolved
Hide resolved
...ednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapdevice/_list.py
Outdated
Show resolved
Hide resolved
...etworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapinterface/_show.py
Show resolved
Hide resolved
src/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_nf_rotate_certificate.py
Show resolved
Hide resolved
...nagednetworkfabric/azext_managednetworkfabric/tests/latest/test_device_resync_certificate.py
Outdated
Show resolved
Hide resolved
...etworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapinterface/_list.py
Outdated
Show resolved
Hide resolved
...etworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapinterface/_wait.py
Show resolved
Hide resolved
src/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_nf_rotate_certificate.py
Show resolved
Hide resolved
…ice, and other actions for existing command groups.
…ice, and other actions for existing command groups.
|
Release version is correct. |
Release version is correct. |
…ice, and other actions for existing command groups.
Managed Network Fabric CLI: enable bootstrap interface, bootstrap device, and other actions for existing command groups
aaz repo: Azure/aaz#976
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.