Skip to content

Conversation

@nguyenm2151
Copy link


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

acr import-pipeline create
acr export-pipeline create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings January 22, 2026 21:17
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @nguyenm2151,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 22, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

Hi @nguyenm2151

Release Suggestions

Module: acrtransfer

  • Please log updates into to src/acrtransfer/HISTORY.rst
  • Update VERSION to 1.1.1b1 in src/acrtransfer/setup.py

Notes

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds breaking change warnings for the acr import-pipeline create and acr export-pipeline create commands to inform users that a new required parameter --storage-access-mode will be added in a future release.

Changes:

  • Added a new _breaking_change.py file that registers breaking change notifications for two ACR pipeline create commands

Comment on lines +1 to +15
# --------------------------------------------------------------------------------------------
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------

from azure.cli.core.breaking_change import register_logic_breaking_change

register_logic_breaking_change('acr export-pipeline create', 'Add required parameter --storage-access-mode',
detail='A new required parameter `--storage-access-mode` will be added. '
'Allowed values: `entra-mi-auth`, `storage-sas-token`.')


register_logic_breaking_change('acr import-pipeline create', 'Add required parameter --storage-access-mode',
detail='A new required parameter `--storage-access-mode` will be added. '
'Allowed values: `entra-mi-auth`, `storage-sas-token`.') No newline at end of file
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _breaking_change module needs to be imported in init.py for the breaking change registrations to take effect. Similar to how _help is imported, add the following import to azext_acrtransfer/init.py:

from azext_acrtransfer._breaking_change import *  # pylint: disable=unused-import,unused-wildcard-import,wildcard-import

Without this import, the register_logic_breaking_change calls will never execute, and users won't see the breaking change warnings.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants