Skip to content

Conversation

@amritas
Copy link
Contributor

@amritas amritas commented Jan 22, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings January 22, 2026 05:19
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jan 22, 2026

⚠️Azure CLI Extensions Breaking Change Test
⚠️trustedsigning
rule cmd_name rule_message suggest_message
⚠️ 1013 - SubgroupPropAdd trustedsigning sub group trustedsigning added property deprecate_info_hide
⚠️ 1013 - SubgroupPropAdd trustedsigning sub group trustedsigning added property deprecate_info_redirect
⚠️ 1013 - SubgroupPropAdd trustedsigning sub group trustedsigning added property deprecate_info_target

@azure-client-tools-bot-prd
Copy link

Hi @amritas,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 22, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR deprecates the trustedsigning Azure CLI extension in favor of the artifact-signing command group. The extension version is bumped from 1.0.0b2 to 1.0.0b3, and deprecation warnings are added to guide users to migrate to the new command group.

Changes:

  • Updated extension version to 1.0.0b3
  • Added deprecation information to the trustedsigning command group
  • Updated documentation to inform users of the deprecation

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/trustedsigning/setup.py Bumped version from 1.0.0b2 to 1.0.0b3
src/trustedsigning/azext_trustedsigning/commands.py Added deprecation info to command group with redirect to artifact-signing
src/trustedsigning/README.md Added deprecation notice at the top of the README
src/trustedsigning/HISTORY.rst Added changelog entry for version 1.0.0b3 and added missing 1.0.0b2 entry

# Azure CLI Trustedsigning Extension #
This is an extension to Azure CLI to manage Trustedsigning resources.
The `trustedsigning` command group has been deprecated and will be removed in a future release.
Use the `artifact-signing` command group instead.
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra leading space at the start of this line. The sentence should start immediately after the line number without the leading space to maintain consistent formatting with the rest of the documentation.

Suggested change
Use the `artifact-signing` command group instead.
Use the `artifact-signing` command group instead.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@yonzhan yonzhan requested a review from necusjz January 22, 2026 07:34
@yonzhan yonzhan requested review from jsntcy and kairu-ms January 22, 2026 07:35
@necusjz
Copy link
Member

necusjz commented Jan 22, 2026

@amritas better to add a screenshot of the outcome in the pr description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants