-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Trustedsigning extension deprecation #9541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| trustedsigning | sub group trustedsigning added property deprecate_info_hide |
||
| trustedsigning | sub group trustedsigning added property deprecate_info_redirect |
||
| trustedsigning | sub group trustedsigning added property deprecate_info_target |
|
Hi @amritas, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR deprecates the trustedsigning Azure CLI extension in favor of the artifact-signing command group. The extension version is bumped from 1.0.0b2 to 1.0.0b3, and deprecation warnings are added to guide users to migrate to the new command group.
Changes:
- Updated extension version to 1.0.0b3
- Added deprecation information to the
trustedsigningcommand group - Updated documentation to inform users of the deprecation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/trustedsigning/setup.py | Bumped version from 1.0.0b2 to 1.0.0b3 |
| src/trustedsigning/azext_trustedsigning/commands.py | Added deprecation info to command group with redirect to artifact-signing |
| src/trustedsigning/README.md | Added deprecation notice at the top of the README |
| src/trustedsigning/HISTORY.rst | Added changelog entry for version 1.0.0b3 and added missing 1.0.0b2 entry |
src/trustedsigning/README.md
Outdated
| # Azure CLI Trustedsigning Extension # | ||
| This is an extension to Azure CLI to manage Trustedsigning resources. | ||
| The `trustedsigning` command group has been deprecated and will be removed in a future release. | ||
| Use the `artifact-signing` command group instead. |
Copilot
AI
Jan 22, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extra leading space at the start of this line. The sentence should start immediately after the line number without the leading space to maintain consistent formatting with the rest of the documentation.
| Use the `artifact-signing` command group instead. | |
| Use the `artifact-signing` command group instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
@amritas better to add a screenshot of the outcome in the pr description. |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.