-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[ContainerApp] adding --kind filter for az containerapp list
#9536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp list | cmd containerapp list added parameter kind |
|
Hi @khushishah513, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Release SuggestionsModule: containerapp
Notes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds a --kind filter parameter to the az containerapp list command, enabling users to filter container apps by their kind property (currently supporting 'functionapp' as an option).
Changes:
- Added
--kindparameter to filter container apps by kind (e.g., 'functionapp') - Updated the list output transformer to include the 'kind' field in results
- Added help documentation and example showing how to list Azure Functions on Container Apps
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/containerapp/azext_containerapp/custom.py | Added kind parameter to list_containerapp function signature |
| src/containerapp/azext_containerapp/containerapp_decorator.py | Implemented filtering logic for kind parameter and added get_argument_kind() method |
| src/containerapp/azext_containerapp/commands.py | Updated import and transformer for list command to use new transformer that includes kind field |
| src/containerapp/azext_containerapp/_transformers.py | Added transform_containerapp_list_output_with_kind function to include kind field in output |
| src/containerapp/azext_containerapp/_params.py | Defined --kind argument with enum type for 'functionapp' value |
| src/containerapp/azext_containerapp/_help.py | Added documentation example showing usage of --kind functionapp |
| src/containerapp/HISTORY.rst | Updated release notes to document the new feature |
| if self.get_argument_kind(): | ||
| containerapps = [c for c in containerapps if c.get("kind") == self.get_argument_kind()] | ||
| return containerapps | ||
|
|
Copilot
AI
Jan 20, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing whitespace detected. Remove the trailing whitespace at the end of this line.
|
|
||
|
|
||
| def list_containerapp(cmd, resource_group_name=None, managed_env=None, environment_type="all"): | ||
| def list_containerapp(cmd, resource_group_name=None, managed_env=None, environment_type="all", kind=None): |
Copilot
AI
Jan 20, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new --kind filter functionality lacks test coverage. Consider adding a test case that verifies filtering container apps by kind, similar to the existing tests for --environment-type filtering. The test should verify that when --kind functionapp is specified, only container apps with kind='functionapp' are returned in the list.
d1822f8 to
068780e
Compare
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.