-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update high log scale cnl logic #9530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update high log scale cnl logic #9530
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @carlotaarvela, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9530 in repo Azure/azure-cli-extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR automatically enables High Log Scale Mode (HLSM) when Container Network Logs (CNL) is specified in az aks create and az aks update commands. The implementation adds validation to ensure that prerequisites (ACNS and monitoring addon) are met and prevents users from explicitly disabling HLSM while enabling CNL.
Changes:
- Auto-enables
--enable-high-log-scale-modewhen--enable-container-network-logsis specified - Validates that ACNS and monitoring addon are enabled when using CNL
- Updates help text to document the auto-enablement behavior
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Version bump to 19.0.0b21 |
| HISTORY.rst | Added changelog entry for the auto-enablement feature |
| _help.py | Updated help text for --enable-container-network-logs and --enable-high-log-scale-mode to document auto-enablement |
| custom.py | Changed default value of enable_high_log_scale_mode parameter from False to None to allow distinguishing between unspecified and explicitly disabled |
| managed_cluster_decorator.py | Implemented get_enable_high_log_scale_mode override with auto-enablement logic and validation; added validation triggers in set_up_addon_profiles and update_monitoring_profile_flow_logs |
| test_managed_cluster_decorator.py | Added 15 comprehensive unit tests covering CREATE and UPDATE scenarios, error cases, and auto-enablement behavior |
This PR automatically enables High Log Scale Mode (HLSM) when Container Network Logs (CNL) is specified in az aks create and az aks update commands.
Changes:
When --enable-container-network-logs is specified, --enable-high-log-scale-mode is automatically set to true
Raises MutuallyExclusiveArgumentError if user explicitly sets --enable-high-log-scale-mode false while enabling CNL
Validates that ACNS and monitoring addon are enabled when using CNL
Updated help text to document the auto-enablement behavior
Testing:
Added 15 unit tests covering CREATE and UPDATE scenarios
Manual testing performed with live Azure clusters
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks cluster create --enable-container-network-logs --enable-acns --enable-addons -a monitoring --enable-high-log-scale-mode
az aks cluster update --enable-container-network-logs --enable-acns --enable-addons -a monitoring --enable-high-log-scale-mode
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.