Skip to content

Conversation

@carlotaarvela
Copy link

@carlotaarvela carlotaarvela commented Jan 16, 2026

This PR automatically enables High Log Scale Mode (HLSM) when Container Network Logs (CNL) is specified in az aks create and az aks update commands.

Changes:

When --enable-container-network-logs is specified, --enable-high-log-scale-mode is automatically set to true
Raises MutuallyExclusiveArgumentError if user explicitly sets --enable-high-log-scale-mode false while enabling CNL
Validates that ACNS and monitoring addon are enabled when using CNL
Updated help text to document the auto-enablement behavior

Testing:

Added 15 unit tests covering CREATE and UPDATE scenarios
Manual testing performed with live Azure clusters


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks cluster create --enable-container-network-logs --enable-acns --enable-addons -a monitoring --enable-high-log-scale-mode
az aks cluster update --enable-container-network-logs --enable-acns --enable-addons -a monitoring --enable-high-log-scale-mode

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @carlotaarvela,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 16, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

@carlotaarvela
Copy link
Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 9530 in repo Azure/azure-cli-extensions

@carlotaarvela carlotaarvela marked this pull request as ready for review January 20, 2026 19:46
Copilot AI review requested due to automatic review settings January 20, 2026 19:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR automatically enables High Log Scale Mode (HLSM) when Container Network Logs (CNL) is specified in az aks create and az aks update commands. The implementation adds validation to ensure that prerequisites (ACNS and monitoring addon) are met and prevents users from explicitly disabling HLSM while enabling CNL.

Changes:

  • Auto-enables --enable-high-log-scale-mode when --enable-container-network-logs is specified
  • Validates that ACNS and monitoring addon are enabled when using CNL
  • Updates help text to document the auto-enablement behavior

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
setup.py Version bump to 19.0.0b21
HISTORY.rst Added changelog entry for the auto-enablement feature
_help.py Updated help text for --enable-container-network-logs and --enable-high-log-scale-mode to document auto-enablement
custom.py Changed default value of enable_high_log_scale_mode parameter from False to None to allow distinguishing between unspecified and explicitly disabled
managed_cluster_decorator.py Implemented get_enable_high_log_scale_mode override with auto-enablement logic and validation; added validation triggers in set_up_addon_profiles and update_monitoring_profile_flow_logs
test_managed_cluster_decorator.py Added 15 comprehensive unit tests covering CREATE and UPDATE scenarios, error cases, and auto-enablement behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants