Skip CRDs with AKS addon manager label #9521

jhmadhav · 2026-01-12T20:17:40Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az connectedk8s

Before deleting each CRD, it now checks for the addonmanager.kubernetes.io/mode: Reconcile label
If the label is present, the CRD is skipped to prevent extensionconfig from going into terminating state
Also fixed a pre-existing bug where communicate() was called twice on a Popen object

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

* forcedelete * format * add code owner * mypy

… '2025-08-01-preview' (#17)

…add E2E coverage and improve logging (#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com>

* add agc overrides * update gns endpoint * add indentation * fix linter error * fix ruff formatting * move overrides to it's own method * update method * update ruff formatting

* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update python version to 3.13 (#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (#17) * [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com> * remove breaking change announcement for removed flags --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com>

azure-client-tools-bot-prd · 2026-01-12T20:17:43Z

Validation for Breaking Change Starting...

Thanks for your contribution!

yonzhan · 2026-01-12T20:18:03Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2026-01-12T20:18:06Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions · 2026-01-12T20:19:06Z

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions · 2026-01-12T20:21:50Z

Hi @jhmadhav

⚠️ Release Requirements

Module: connectedk8s

⚠️ Please update VERSION to be 1.11.1 in src/connectedk8s/setup.py

Module: k8s-extension

Please log updates into to src/k8s-extension/HISTORY.rst
Update VERSION to 1.7.1 in src/k8s-extension/setup.py

Notes

For more info about extension versioning, please refer to Extension version schema

Copilot

Pull request overview

This pull request enhances the connectedk8s extension to skip deletion of CRDs managed by AKS addon manager during Arc onboarding, preventing extensionconfig from entering a terminating state. The PR also fixes a bug where communicate() was called twice on Popen objects, corrects MCR endpoint URLs for government clouds, and removes deprecated RBAC parameters.

Changes:

Adds CRD label checking to skip deletion of AKS-managed CRDs during force delete operations
Fixes double communicate() call bug on Popen objects
Updates MCR path logic for US Government and China clouds
Removes hardcoded ARM endpoint URLs and deprecated RBAC parameters
Adds comprehensive Pester-based integration test suite for connectedk8s scenarios

Reviewed changes

Copilot reviewed 31 out of 35 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/connectedk8s/azext_connectedk8s/custom.py	Implements CRD label checking, fixes Popen communicate() bug, removes deprecated parameters
src/connectedk8s/azext_connectedk8s/_utils.py	Updates MCR path logic for government clouds, adds AGC endpoint overrides
src/connectedk8s/azext_connectedk8s/_client_factory.py	Removes hardcoded base_url for ARM endpoints
src/connectedk8s/azext_connectedk8s/_params.py	Removes deprecated RBAC parameters
src/connectedk8s/azext_connectedk8s/_breaking_change.py	Deleted file (no longer needed after parameter removal)
src/connectedk8s/azext_connectedk8s/tests/unittests/test_utils_.py	Adds unit tests for MCR path logic
src/k8s-extension/azext_k8s_extension/utils.py	Updates MCR path logic to match connectedk8s
testing/*	Adds comprehensive Pester test infrastructure and test scenarios
src/connectedk8s/HISTORY.rst	Documents changes across three versions
src/connectedk8s/setup.py	Bumps version to 1.10.13

Bavneet Singh and others added 15 commits September 30, 2025 09:40

add pester tests for connectedk8s cli extension

20aecd7

Pass the force delete param to the API call (#4)

40926a3

* forcedelete * format * add code owner * mypy

fix CI testcases for nodepool image issues (#8)

8f068a8

update python version to 3.13 (#12)

ad1ce1d

changes to support gateway association/disassociation for api version…

2121694

… '2025-08-01-preview' (#17)

Merge branch 'Azure:main' into main

ed5b5e2

remove hardcoded public ARM endpoint url for fairfax and mooncake (#24)

9038227

Bug Fix for FFX mcr url (#22)

002220d

[connectedk8s] update release notes and version (#26)

6c0a24b

Add Helm Overrides for AGC (#23)

3ca7ae1

* add agc overrides * update gns endpoint * add indentation * fix linter error * fix ruff formatting * move overrides to it's own method * update method * update ruff formatting

update prediag version (#27)

979a4c3

Updating the proxy version constant (#28)

09119b8

skip aks crd during delete

d75be1a

Copilot AI review requested due to automatic review settings January 12, 2026 20:17

azure-client-tools-bot-prd bot added this to the February 2026 (2026-02-03) milestone Jan 12, 2026

microsoft-github-policy-service bot requested review from FumingZhang, jsntcy, yanzhudd, yonzhan and zhoxing-ms January 12, 2026 20:18

microsoft-github-policy-service bot assigned yanzhudd and zhoxing-ms Jan 12, 2026

microsoft-github-policy-service bot added Auto-Assign Auto assign by bot AKS Connected Kubernetes labels Jan 12, 2026

jhmadhav changed the title ~~Hejakkam/skip aks crd~~ Skip CRDs with AKS addon manager label Jan 12, 2026

Copilot started reviewing on behalf of jhmadhav January 12, 2026 20:18 View session

jhmadhav closed this Jan 12, 2026

github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 12, 2026

Copilot AI reviewed Jan 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Skip CRDs with AKS addon manager label #9521

Skip CRDs with AKS addon manager label #9521

Uh oh!

jhmadhav commented Jan 12, 2026

Uh oh!

azure-client-tools-bot-prd bot commented Jan 12, 2026

Uh oh!

yonzhan commented Jan 12, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Skip CRDs with AKS addon manager label #9521

Skip CRDs with AKS addon manager label #9521

Uh oh!

Conversation

jhmadhav commented Jan 12, 2026

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Jan 12, 2026

Uh oh!

yonzhan commented Jan 12, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

CodeGen Tools Feedback Collection

Uh oh!

github-actions bot commented Jan 12, 2026

⚠️ Release Requirements

Module: connectedk8s

Module: k8s-extension

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants