Fix Gateway API tests to accommodate the removal of its prerequisite - managed Gateway API ingress provider enablement no longer required #9520
Conversation
…- managed Gateway API ingress provider enablement no longer required
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Winbobob, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
This PR removes the prerequisite that Gateway API requires an enabled managed Gateway API ingress provider (such as Azure Service Mesh). The changes update documentation, tests, and release notes to reflect that --enable-gateway-api can now be used independently.
Changes:
- Updated help text to remove the prerequisite requirement from parameter descriptions and examples
- Renamed and updated test to better reflect its scope (create AND update operations)
- Removed test that validated the old prerequisite enforcement
- Added TODO for future test covering standalone Gateway API usage
- Updated HISTORY.rst with proper formatting and new entry describing the change
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Renamed test function for clarity, removed test validating old prerequisite behavior, added TODO for future standalone Gateway API test |
| src/aks-preview/azext_aks_preview/_help.py | Removed prerequisite mention from --enable-gateway-api parameter descriptions for both create and update commands, simplified example to not require Azure Service Mesh |
| src/aks-preview/HISTORY.rst | Fixed bullet point indentation for Application Load Balancer entry, added new entry documenting the prerequisite removal |
jaiveerk
left a comment
jaiveerk
left a comment
There was a problem hiding this comment.
lgtm with question about release documentation
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| random_name_length=17, name_prefix="clitest", location="centraluseuap" | ||
| ) | ||
| def test_aks_create_with_gateway_api_and_azureservicemesh( | ||
| def test_aks_create_and_update_with_gateway_api_and_azureservicemesh( |
There was a problem hiding this comment.
Queued live test to validate the change, test passed!
|
[Release] Update index.json for extension [ aks-preview-19.0.0b19 ] : https://dev.azure.com/msazure/One/_build/results?buildId=149436674&view=results |
Winbobob
deleted the
zheweihu/f/remove-gateway-api-cli-managed-impl-enablement-check
branch
7 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create:--enable-gateway-apiflagaz aks update:--enable-gateway-apiflagGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.