-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Bugfixes in repair-and-restore, repair, and redacting sensitive data from logs #9514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request addresses several important bugfixes and improvements in the vm-repair Azure CLI extension, bumping the version from 2.1.2 to 2.1.3.
Key Changes:
- Fixed Python 3.13 compatibility issue with
inspect.getargvalues()returningFrameLocalsProxyinstead of a dict - Fixed restore command bug where disk name was used instead of full disk ID for managed disks (affects az-cli 2.81+)
- Added security improvements to redact sensitive credentials (username/password) from logs
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Version bump to 2.1.3 and added Python 3.13 classifier |
| HISTORY.rst | Documented changes for version 2.1.3 release |
| repair_utils.py | Fixed Python 3.13 compatibility, updated _fetch_disk_info to return disk ID, added credential redaction in logging, removed unused imports, formatting fixes |
| custom.py | Updated to use full disk ID in restore function, removed unused imports, formatting fixes (whitespace removal) |
| commands.py | Removed trailing blank line |
| _validators.py | Added blank lines for PEP 8 compliance |
| _params.py | Added blank lines for PEP 8 compliance |
| _help.py | Removed trailing whitespace |
|
@zhoxing-ms / @yonzhan / @yanzhudd |
|
Please fix CI issues |
|
Could you please add some test cases for this PR change? |
|
CI failures addressed, tests were found to exist already. While examining the tests I found that most of the Linux tests were referencing outdated images and/or they did not match the function names, so I fixed that. |
|
[Release] Update index.json for extension [ vm-repair-2.1.3 ] : https://dev.azure.com/msazure/One/_build/results?buildId=149606691&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az vm repair repair-button --verbose --button-command 'fstab' --resource-group RGNAME --name VMNAME
after manually creating a repair-vm
az vm repair restore --verbose --resource-group RGNAME --name VMNAME
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.