Skip to content

Conversation

@pagienge
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az vm repair repair-button --verbose --button-command 'fstab' --resource-group RGNAME --name VMNAME

after manually creating a repair-vm
az vm repair restore --verbose --resource-group RGNAME --name VMNAME

General Guidelines

  • [Y] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [Y] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [Y] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings January 10, 2026 01:43
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jan 10, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 10, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses several important bugfixes and improvements in the vm-repair Azure CLI extension, bumping the version from 2.1.2 to 2.1.3.

Key Changes:

  • Fixed Python 3.13 compatibility issue with inspect.getargvalues() returning FrameLocalsProxy instead of a dict
  • Fixed restore command bug where disk name was used instead of full disk ID for managed disks (affects az-cli 2.81+)
  • Added security improvements to redact sensitive credentials (username/password) from logs

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
setup.py Version bump to 2.1.3 and added Python 3.13 classifier
HISTORY.rst Documented changes for version 2.1.3 release
repair_utils.py Fixed Python 3.13 compatibility, updated _fetch_disk_info to return disk ID, added credential redaction in logging, removed unused imports, formatting fixes
custom.py Updated to use full disk ID in restore function, removed unused imports, formatting fixes (whitespace removal)
commands.py Removed trailing blank line
_validators.py Added blank lines for PEP 8 compliance
_params.py Added blank lines for PEP 8 compliance
_help.py Removed trailing whitespace

@pagienge
Copy link
Contributor Author

@zhoxing-ms / @yonzhan / @yanzhudd
Any comment on this PR? Given one of the drivers of this was an MSRC issue you sent specifically to me, I would appreciate some response

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 15, 2026

Please fix CI issues

@zhoxing-ms
Copy link
Contributor

Could you please add some test cases for this PR change?

@pagienge
Copy link
Contributor Author

CI failures addressed, tests were found to exist already. While examining the tests I found that most of the Linux tests were referencing outdated images and/or they did not match the function names, so I fixed that.

@zhoxing-ms zhoxing-ms merged commit 054e27d into Azure:main Jan 16, 2026
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ vm-repair-2.1.3 ] : https://dev.azure.com/msazure/One/_build/results?buildId=149606691&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Compute

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants