Skip to content

Fix inconsistent parameter name normalization for reserved keywords in spread body operations #3679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
v-jiaodi wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix inconsistent parameter name normalization for reserved keywords in spread body operations #3679

v-jiaodi wants to merge 8 commits into from
+129 −3

Conversation

@v-jiaodi
Copy link
Member

@v-jiaodi v-jiaodi commented Jan 12, 2026

fixes #3678

v-jiaodi
v-jiaodi commented Jan 14, 2026
View reviewed changes
packages/typespec-ts/test/modularUnit/scenarios/operations/overrideReservedkeywords.md
context: Client,
apiVersion: string,
name: string,
typeParam: string,
Copy link
Member Author

@v-jiaodi v-jiaodi Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generate typeParam
image

v-jiaodi
v-jiaodi commented Jan 14, 2026
View reviewed changes
packages/typespec-ts/test/modularUnit/scenarios/operations/overrideReservedkeywords.md
.post({
...operationOptionsToRequestParameters(options),
contentType: "application/json",
body: { name: name, type: typeParam },
Copy link
Member Author

@v-jiaodi v-jiaodi Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@qiaozha qiaozha assigned JialinHuang803 and unassigned MaryGao Jan 21, 2026
@v-jiaodi v-jiaodi marked this pull request as ready for review January 21, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JialinHuang803 JialinHuang803 JialinHuang803 approved these changes

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner

Assignees

@v-jiaodi v-jiaodi

@JialinHuang803 JialinHuang803

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[migration tsp] type parameter name normalization for reserved keywords in spread body operations

3 participants

@v-jiaodi @JialinHuang803 @MaryGao