Skip to content

Update LRO related test case #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
haolingdong-msft wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update LRO related test case #371

haolingdong-msft wants to merge 2 commits into from

Conversation

@haolingdong-msft
Copy link
Member

@haolingdong-msft haolingdong-msft commented Mar 17, 2022 •
edited
Loading

Change:

  1. add LRO related calls for "/customization/lro/{mode}". Use this pattern https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#long-running-operations-with-status-monitor as DefaultPollingStrategy only supports this pattern.

@haolingdong-msft haolingdong-msft self-assigned this Mar 17, 2022
weidongxu-microsoft
weidongxu-microsoft reviewed Mar 21, 2022
View reviewed changes
src/test-routes/dpg/customization.ts

app.get("/customization/lro/raw/operationResults/1", "GetRawLROResult", (req) => {
return {
status: 202,
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 200?

src/test-routes/dpg/customization.ts

app.get("/customization/lro/raw", "GetRawLROFinalResult", (req) => {
return {
status: 202,
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

200?

swagger/dpg-customization.json
Comment on lines +103 to +108
"headers": {
"Operation-Location": {
"description": "Location to poll for final status: will be set to /customization/lro/{mode}/operationResults/1",
"type": "string"
}
},
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure whether this is required or not, as API is defined as LRO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft left review comments

Assignees

@haolingdong-msft haolingdong-msft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haolingdong-msft @weidongxu-microsoft