Skip to content

Conversation

@iscai-msft
Copy link
Contributor

No description provided.

…into special_paging

* 'master' of https://github.com/Azure/autorest.testserver:
  add test for error deserialization in op with param name 'models' (#234)
  add test for first response no items, second response with items (#235)
@iscai-msft iscai-msft marked this pull request as draft November 11, 2020 16:43
@iscai-msft iscai-msft requested a review from lmazuel November 14, 2020 00:32
@iscai-msft iscai-msft marked this pull request as ready for review November 14, 2020 00:32
"paths": {
"/pagingSpecial/nextLinkInResponseHeaders": {
"get": {
"x-ms-pageable": { "nextLinkName": null},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to set nextLinkName to ""x-ms-nextLink" instead of null?

Looking at the docs for x-ms-pageable, and as I understand it, setting nextLinkName to null would mean that there is no next operation to call. However in this scenario there is, and there is also a nextLink, it is just not in the requestBody.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants