Skip to content

FIX align platform oai key #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hannahwestra25 wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −7
Open

FIX align platform oai key #1522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34c07c1
align oai platform string
hannahwestra25 Mar 19, 2026
d8ecd1f
missed one
hannahwestra25 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .env_example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
###################################

PLATFORM_OPENAI_CHAT_ENDPOINT="https://api.openai.com/v1"
PLATFORM_OPENAI_CHAT_API_KEY="sk-xxxxx"
PLATFORM_OPENAI_CHAT_KEY="sk-xxxxx"
PLATFORM_OPENAI_CHAT_GPT4O_MODEL="gpt-4o"

# Note: For Azure OpenAI endpoints, use the new format with /openai/v1 and specify the model separately
Expand Down Expand Up @@ -79,7 +79,7 @@ DEFAULT_OPENAI_FRONTEND_KEY = ${AZURE_OPENAI_GPT4O_AAD_KEY}
DEFAULT_OPENAI_FRONTEND_MODEL = "gpt-4o"

OPENAI_CHAT_ENDPOINT=${PLATFORM_OPENAI_CHAT_ENDPOINT}
OPENAI_CHAT_KEY=${PLATFORM_OPENAI_CHAT_API_KEY}
OPENAI_CHAT_KEY=${PLATFORM_OPENAI_CHAT_KEY}
OPENAI_CHAT_MODEL=${PLATFORM_OPENAI_CHAT_GPT4O_MODEL}
# The following line can be populated if using an Azure OpenAI deployment
# where the deployment name differs from the actual underlying model
Expand Down
2 changes: 1 addition & 1 deletion .env_local_example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

# This will override the .env value for your default OpenAIChatTarget
OPENAI_CHAT_ENDPOINT=${PLATFORM_OPENAI_CHAT_ENDPOINT}
OPENAI_CHAT_KEY=${PLATFORM_OPENAI_CHAT_API_KEY}
OPENAI_CHAT_KEY=${PLATFORM_OPENAI_CHAT_KEY}
OPENAI_CHAT_MODEL="gpt-4o"


Expand Down
2 changes: 1 addition & 1 deletion pyrit/setup/initializers/components/targets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class TargetConfig:
registry_name="platform_openai_chat",
target_class=OpenAIChatTarget,
endpoint_var="PLATFORM_OPENAI_CHAT_ENDPOINT",
key_var="PLATFORM_OPENAI_CHAT_API_KEY",
key_var="PLATFORM_OPENAI_CHAT_KEY",
model_var="PLATFORM_OPENAI_CHAT_GPT4O_MODEL",
),
TargetConfig(
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/setup/test_targets_initializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ async def test_initialize_runs_without_error_no_env_vars(self):
async def test_registers_target_when_env_vars_set(self):
"""Test that a target is registered when its env vars are set."""
os.environ["PLATFORM_OPENAI_CHAT_ENDPOINT"] = "https://api.openai.com/v1"
os.environ["PLATFORM_OPENAI_CHAT_API_KEY"] = "test_key"
os.environ["PLATFORM_OPENAI_CHAT_KEY"] = "test_key"
os.environ["PLATFORM_OPENAI_CHAT_GPT4O_MODEL"] = "gpt-4o"

init = TargetInitializer()
Expand All @@ -79,7 +79,7 @@ async def test_registers_target_when_env_vars_set(self):
async def test_does_not_register_target_without_endpoint(self):
"""Test that target is not registered if endpoint is missing."""
# Only set key, not endpoint
os.environ["PLATFORM_OPENAI_CHAT_API_KEY"] = "test_key"
os.environ["PLATFORM_OPENAI_CHAT_KEY"] = "test_key"
os.environ["PLATFORM_OPENAI_CHAT_GPT4O_MODEL"] = "gpt-4o"

init = TargetInitializer()
Expand All @@ -106,7 +106,7 @@ async def test_registers_multiple_targets(self):
"""Test that multiple targets are registered when their env vars are set."""
# Set up platform_openai_chat
os.environ["PLATFORM_OPENAI_CHAT_ENDPOINT"] = "https://api.openai.com/v1"
os.environ["PLATFORM_OPENAI_CHAT_API_KEY"] = "test_key"
os.environ["PLATFORM_OPENAI_CHAT_KEY"] = "test_key"
os.environ["PLATFORM_OPENAI_CHAT_GPT4O_MODEL"] = "gpt-4o"

# Set up openai_image_platform (uses ENDPOINT2/KEY2/MODEL2)
Expand Down
Loading