Resolve config-relative paths from the config file directory#1502
Open
biefan wants to merge 1 commit intoAzure:mainfrom
Open
Resolve config-relative paths from the config file directory#1502biefan wants to merge 1 commit intoAzure:mainfrom
biefan wants to merge 1 commit intoAzure:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initialization_scriptsandenv_filesfrom the configuration file directory when loading YAML config filesfrom_yaml_file()andload_with_overrides(config_file=...)Problem
ConfigurationLoadercurrently resolves relativeinitialization_scriptsandenv_filesfrom the caller's working directory. When a config file lives in another directory, values like./scripts/init.pyor./env/local.envpoint to the wrong files.Validation
.venv/bin/pytest tests/unit/setup -q.venv/bin/ruff check pyrit/setup/configuration_loader.py tests/unit/setup/test_configuration_loader.py