Skip to content

Preserve raw HTTP body whitespace in HTTPTarget #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
biefan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Preserve raw HTTP body whitespace in HTTPTarget #1495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pyrit/prompt_target/http_target/http_target.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,9 @@ def parse_raw_http_request(self, http_request: str) -> tuple[dict[str, str], Req

body = ""

# Split the request into headers and body by finding the double newlines (\n\n)
request_parts = http_request.strip().split("\n\n", 1)
# Split the request into headers and body by finding the double newlines (\n\n).
# Preserve body whitespace exactly as provided in the raw request.
request_parts = http_request.split("\n\n", 1)

# Parse out the header components
header_lines = request_parts[0].strip().split("\n")
Expand Down
13 changes: 13 additions & 0 deletions tests/unit/target/test_http_target_parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,19 @@ def test_parse_raw_http_request_preserves_relative_url_case(sqlite_instance):
assert version == "HTTP/1.1"


def test_parse_raw_http_request_preserves_body_trailing_whitespace(sqlite_instance):
request = "POST /submit HTTP/1.1\nHost: example.com\nContent-Type: text/plain\n\nhello \n"
target = HTTPTarget(http_request=request)

headers, body, url, method, version = target.parse_raw_http_request(request)

assert url == "https://example.com/submit"
assert method == "POST"
assert headers == {"host": "example.com", "content-type": "text/plain"}
assert body == "hello \n"
assert version == "HTTP/1.1"


def test_parse_regex_response_no_match():
mock_response = MagicMock()
mock_response.content = b"<html><body>No match here</body></html>"
Expand Down