Respect export type in SQLite conversation exports#1493
Open
biefan wants to merge 1 commit intoAzure:mainfrom
Open
Respect export type in SQLite conversation exports#1493biefan wants to merge 1 commit intoAzure:mainfrom
biefan wants to merge 1 commit intoAzure:mainfrom
Conversation
romanlutz
approved these changes
Mar 18, 2026
| os.remove(file_path) | ||
|
|
||
|
|
||
| def test_export_all_conversations_with_scores_markdown_format(sqlite_instance: MemoryInterface): |
Contributor
There was a problem hiding this comment.
Please parametrize these tests to run for json, md, CSV and just separate out the differences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLiteMemory.export_conversations()honor the requestedexport_typeMemoryExporterinstead of always writing JSONProblem
SQLiteMemory.export_conversations()accepts anexport_typeargument, but the current implementation ignores it and always writes JSON directly.That means calls such as:
export_conversations(..., export_type="csv")export_conversations(..., export_type="md")still produce JSON content, even though the exporter infrastructure already supports those formats.
This makes the SQLite backend behave differently from the rest of the export stack and breaks callers that rely on the requested file format.
Testing
.venv/bin/pytest tests/unit/memory/memory_interface/test_interface_export.py -q