Preserve request params and validate upload files in HTTPXAPITarget#1487
Open
biefan wants to merge 3 commits intoAzure:mainfrom
Open
Preserve request params and validate upload files in HTTPXAPITarget#1487biefan wants to merge 3 commits intoAzure:mainfrom
biefan wants to merge 3 commits intoAzure:mainfrom
Conversation
hannahwestra25
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paramsfor non-GETHTTPXAPITargetrequestsparamsfor file-upload requests as well as JSON/form requestsFileNotFoundErrorwhen an explicitly provided upload path does not existProblem
HTTPXAPITargetexposes aparamsconstructor argument, butsend_prompt_async()currently drops it outside theGET/HEADpath. That affects both standard API calls and file-upload requests.The same method also accepts an explicit
file_path, and its docstring says a missing file should raiseFileNotFoundError. In practice, if that path does not exist, the upload branch is silently skipped and the request falls back to a normal non-upload request.Examples that currently behave incorrectly:
POST /endpoint?alpha=1withjson_data=...POST /upload?alpha=1withfile_path=...file_pathpointing to a missing fileThis makes valid API patterns impossible to express and hides configuration mistakes that should fail fast.
Testing
.venv/bin/pytest tests/unit/target/test_http_api_target.py -q