-
Notifications
You must be signed in to change notification settings - Fork 46
Update uninstall commands for Az.Accounts #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
60ed95f
Update uninstall commands for Az.Accounts
erskinejohn 0aca626
Initial plan
Copilot 1613c71
Initial plan
Copilot a98d07b
Update TSG/EnvironmentValidator/Troubleshooting-MSI-Does-Not-Have-Acc…
erskinejohn 5c2abf3
Update TSG/EnvironmentValidator/Troubleshooting-MSI-Does-Not-Have-Acc…
erskinejohn 07c034e
Update TSG/EnvironmentValidator/Troubleshooting-MSI-Does-Not-Have-Acc…
erskinejohn 41a0272
Merge pull request #216 from Azure/copilot/sub-pr-206
erskinejohn 9d6238c
Merge pull request #217 from Azure/copilot/sub-pr-206-again
erskinejohn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
-Forceparameter onUninstall-Moduleis potentially unsafe for production environments as it suppresses all prompts and warnings. Consider removing-Forceto allow users to review what will be uninstalled, or add defensive checks before uninstalling (e.g., verify which versions will be removed). Additionally, this complex one-liner lacks error handling - consider using$ErrorActionPreference = "Stop"at the beginning of the script or adding try-catch blocks to handle potential failures gracefully.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback