Skip to content

Conversation

@bcherryp2
Copy link

Added updates to the ANF section and added ANF sections to 3 specialized workloads

Added ANF sections to the AVD, SAP, and AVS specialized workload recommendations. also added 2 optimization, one security, and one HA recommendations to the ANF section.

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@bcherryp2 bcherryp2 requested review from a team as code owners April 1, 2025 16:03
@tksh164 tksh164 changed the title ANF updates to the APRL library feat: ANF updates to the APRL library Apr 30, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Enhancement 🆕 New feature or request label Apr 30, 2025
@microsoft-github-policy-service

@bcherryp2 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Copy link
Member

@tksh164 tksh164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcherryp2 - Please update the following points.

azure-resources/NetApp/netAppAccounts/recommendations.yaml:
    Wrong line endings or no final newline
    221: Trailing whitespace
    230: Trailing whitespace
    238: Trailing whitespace
    247: Trailing whitespace
    255: Trailing whitespace
    255: Wrong amount of left-padding spaces(want multiple of 2)
    264: Trailing whitespace
    271: Trailing whitespace
    272: Trailing whitespace
    281: Trailing whitespace
    281: Wrong amount of left-padding spaces(want multiple of 2)

azure-specialized-workloads/avd/recommendations.yaml:
    445: Trailing whitespace
    460: Trailing whitespace

azure-specialized-workloads/avs/recommendations.yaml:
    153: Trailing whitespace
    168: Trailing whitespace

azure-specialized-workloads/sap/recommendations.yaml:
    357: Trailing whitespace
    373: Trailing whitespace

@tksh164
Copy link
Member

tksh164 commented Jun 11, 2025

@bcherryp2 - Would you fix the following points?

./azure-resources/NetApp/netAppAccounts/recommendations.yaml

  • longDescription is should be less than 300 characters.

    Azure NetApp Files with cool access allows you to have inactive data transparently tiered from Azure NetApp Files storage (the hot tier) to an Azure storage account (the cool tier). This option lets you free up storage that resides within Azure NetApp Files volumes by moving data blocks to the lower cost cool tier, resulting in overall cost savings.

  • potentialBenefits is should be less than 60 characters.

    Cost Savings for workloads with infrequently accessed data and no latency requirements

    Point in time recovery point for Oracle, Db2, and SAP HANA databases

./azure-specialized-workloads/avs/recommendations.yaml

  • longDescription is should be less than 300 characters.

    Azure VMware Solution supports attaching Network File System (NFS) datastores as a persistent storage option. You can create NFS datastores with Azure NetApp Files volumes and attach them to clusters of your choice. You can also create virtual machines (VMs) on different Azure NetApp Files datastores for optimal cost and performance.

./azure-specialized-workloads/sap/recommendations.yaml

  • potentialBenefits is should be less than 60 characters.

    Azure NetApp Files provides on-demand scalability, allowing to adjust both performance and capacity as needed

Copy link
Member

@tksh164 tksh164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you fix the commented points?

recommendationResourceType: Microsoft.NetApp/netAppAccounts
recommendationMetadataState: Active
longDescription: |
Azure NetApp Files with cool access allows you to have inactive data transparently tiered from Azure NetApp Files storage (the hot tier) to an Azure storage account (the cool tier). This option lets you free up storage that resides within Azure NetApp Files volumes by moving data blocks to the lower cost cool tier, resulting in overall cost savings.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

longDescription is should be less than 300 characters. The current text has 351 characters.

recommendationResourceType: Microsoft.NetApp/netAppAccounts
recommendationMetadataState: Active
longDescription: |
Azure VMware Solution supports attaching Network File System (NFS) datastores as a persistent storage option. You can create NFS datastores with Azure NetApp Files volumes and attach them to clusters of your choice. You can also create virtual machines (VMs) on different Azure NetApp Files datastores for optimal cost and performance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

longDescription is should be less than 300 characters. The current text has 335 characters.

recommendationMetadataState: Active
longDescription: |
Azure NetApp Files with cool access allows you to have inactive data transparently tiered from Azure NetApp Files storage (the hot tier) to an Azure storage account (the cool tier). This option lets you free up storage that resides within Azure NetApp Files volumes by moving data blocks to the lower cost cool tier, resulting in overall cost savings.
potentialBenefits: Cost Savings for workloads with infrequently accessed data and no latency requirements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potentialBenefits is should be less than 60 characters. The current text has 86 characters.

recommendationMetadataState: Active
longDescription: |
Azure Application Consistent Snapshot Tool (AzAcSnap) is a command-line tool that enables customers to simplify data protection for third-party databases in Linux environments.
potentialBenefits: Point in time recovery point for Oracle, Db2, and SAP HANA databases
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potentialBenefits is should be less than 60 characters. The current text has 68 characters.

recommendationMetadataState: Active
longDescription: |
Azure NetApp Files offers high-performance, sub-millisecond latency for SAP. Certified for SAP HANA and supports AnyDB like Oracle, DB2, ASE, it's ideal for various SAP landscapes.
potentialBenefits: Azure NetApp Files provides on-demand scalability, allowing to adjust both performance and capacity as needed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potentialBenefits is should be less than 60 characters. The current text has 109 characters.

@arthurclares
Copy link
Collaborator

Hello @bcherryp2
Can you please review this PR?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Azure NetApp Files (ANF) recommendations to both the core ANF service and three specialized workloads (SAP, AVS, and AVD). The changes expand the APRL library with ANF-specific guidance for optimization, security, and high availability scenarios.

  • Adds 4 new recommendations to the core ANF service covering cost optimization, security, and backup capabilities
  • Integrates ANF recommendations into SAP, AVS, and AVD specialized workload guidance
  • Provides workload-specific ANF usage patterns and benefits for each specialized scenario

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
azure-resources/NetApp/netAppAccounts/recommendations.yaml Adds 4 new ANF recommendations for Cool Access, Reserved Capacity, Customer Managed Keys, and AzAcSnap
azure-specialized-workloads/sap/recommendations.yaml Adds ANF recommendation for SAP IaaS deployments
azure-specialized-workloads/avs/recommendations.yaml Adds ANF recommendation as datastore for Azure VMware Solution
azure-specialized-workloads/avd/recommendations.yaml Adds ANF recommendation for FSLogix profiles in AVD

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

arthurclares and others added 2 commits September 17, 2025 10:20
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement 🆕 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants