-
Notifications
You must be signed in to change notification settings - Fork 117
feat: ANF updates to the APRL library #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@bcherryp2 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcherryp2 - Please update the following points.
azure-resources/NetApp/netAppAccounts/recommendations.yaml:
Wrong line endings or no final newline
221: Trailing whitespace
230: Trailing whitespace
238: Trailing whitespace
247: Trailing whitespace
255: Trailing whitespace
255: Wrong amount of left-padding spaces(want multiple of 2)
264: Trailing whitespace
271: Trailing whitespace
272: Trailing whitespace
281: Trailing whitespace
281: Wrong amount of left-padding spaces(want multiple of 2)
azure-specialized-workloads/avd/recommendations.yaml:
445: Trailing whitespace
460: Trailing whitespace
azure-specialized-workloads/avs/recommendations.yaml:
153: Trailing whitespace
168: Trailing whitespace
azure-specialized-workloads/sap/recommendations.yaml:
357: Trailing whitespace
373: Trailing whitespace
|
@bcherryp2 - Would you fix the following points? ./azure-resources/NetApp/netAppAccounts/recommendations.yaml
./azure-specialized-workloads/avs/recommendations.yaml
./azure-specialized-workloads/sap/recommendations.yaml
|
tksh164
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you fix the commented points?
| recommendationResourceType: Microsoft.NetApp/netAppAccounts | ||
| recommendationMetadataState: Active | ||
| longDescription: | | ||
| Azure NetApp Files with cool access allows you to have inactive data transparently tiered from Azure NetApp Files storage (the hot tier) to an Azure storage account (the cool tier). This option lets you free up storage that resides within Azure NetApp Files volumes by moving data blocks to the lower cost cool tier, resulting in overall cost savings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
longDescription is should be less than 300 characters. The current text has 351 characters.
| recommendationResourceType: Microsoft.NetApp/netAppAccounts | ||
| recommendationMetadataState: Active | ||
| longDescription: | | ||
| Azure VMware Solution supports attaching Network File System (NFS) datastores as a persistent storage option. You can create NFS datastores with Azure NetApp Files volumes and attach them to clusters of your choice. You can also create virtual machines (VMs) on different Azure NetApp Files datastores for optimal cost and performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
longDescription is should be less than 300 characters. The current text has 335 characters.
| recommendationMetadataState: Active | ||
| longDescription: | | ||
| Azure NetApp Files with cool access allows you to have inactive data transparently tiered from Azure NetApp Files storage (the hot tier) to an Azure storage account (the cool tier). This option lets you free up storage that resides within Azure NetApp Files volumes by moving data blocks to the lower cost cool tier, resulting in overall cost savings. | ||
| potentialBenefits: Cost Savings for workloads with infrequently accessed data and no latency requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potentialBenefits is should be less than 60 characters. The current text has 86 characters.
| recommendationMetadataState: Active | ||
| longDescription: | | ||
| Azure Application Consistent Snapshot Tool (AzAcSnap) is a command-line tool that enables customers to simplify data protection for third-party databases in Linux environments. | ||
| potentialBenefits: Point in time recovery point for Oracle, Db2, and SAP HANA databases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potentialBenefits is should be less than 60 characters. The current text has 68 characters.
| recommendationMetadataState: Active | ||
| longDescription: | | ||
| Azure NetApp Files offers high-performance, sub-millisecond latency for SAP. Certified for SAP HANA and supports AnyDB like Oracle, DB2, ASE, it's ideal for various SAP landscapes. | ||
| potentialBenefits: Azure NetApp Files provides on-demand scalability, allowing to adjust both performance and capacity as needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potentialBenefits is should be less than 60 characters. The current text has 109 characters.
|
Hello @bcherryp2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Azure NetApp Files (ANF) recommendations to both the core ANF service and three specialized workloads (SAP, AVS, and AVD). The changes expand the APRL library with ANF-specific guidance for optimization, security, and high availability scenarios.
- Adds 4 new recommendations to the core ANF service covering cost optimization, security, and backup capabilities
- Integrates ANF recommendations into SAP, AVS, and AVD specialized workload guidance
- Provides workload-specific ANF usage patterns and benefits for each specialized scenario
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| azure-resources/NetApp/netAppAccounts/recommendations.yaml | Adds 4 new ANF recommendations for Cool Access, Reserved Capacity, Customer Managed Keys, and AzAcSnap |
| azure-specialized-workloads/sap/recommendations.yaml | Adds ANF recommendation for SAP IaaS deployments |
| azure-specialized-workloads/avs/recommendations.yaml | Adds ANF recommendation as datastore for Azure VMware Solution |
| azure-specialized-workloads/avd/recommendations.yaml | Adds ANF recommendation for FSLogix profiles in AVD |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Added updates to the ANF section and added ANF sections to 3 specialized workloads
Added ANF sections to the AVD, SAP, and AVS specialized workload recommendations. also added 2 optimization, one security, and one HA recommendations to the ANF section.
mainbranch