fix: flaky localdns exporter e2e validation#8454
Open
jingwenw15 wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes flakiness in the LocalDNS exporter E2E validation script by avoiding pipefail-related false negatives when grepping large metrics payloads.
Changes:
- Cache
ss -tlnoutput and reuse it for port checks and listen address detection. - Replace
echo "$VAR" | grep ...patterns with here-strings (grep ... <<< "$VAR") to avoid SIGPIPE/pipefailfailures. - Minor refactors to avoid pipelines (e.g.,
head,grep | sed) when inspecting$METRICS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
echo "$VAR" | grep/awk/sedpipes withgrep/awk/sed <<< "$VAR"here-strings throughout the exporter validation scriptss -tlnoutput once into a variable (SS_LISTEN_OUTPUT) instead of callingssmultiple timesecho "$METRICS" | grep ... | head -10withawkone-liners that exit after 10 matchesWhy: With
set -euo pipefailenabled,echo "$LARGE_VAR" | grep -q ...can fail spuriously. Ifgrepfinds its match and exits early,echoreceives SIGPIPE and returns a non-zero exit status, whichpipefailtreats as a command failure. Here-strings (<<<) avoid the pipe entirely — the shell passes the variable directly to the command's stdin via a temporary file, so there is no writer process to receive SIGPIPE.This was the root cause of intermittent test failures in the exporter e2e where metrics were present but the validation still failed.