test: verify hotfix-generate GH Action on official/v20260320 by Devinwong · Pull Request #8147 · Azure/AgentBaker

Devinwong · 2026-03-20T23:27:55Z

Test PR for hotfix-generate GH Action

End-to-end test of the hotfix-generate workflow (PR #8131).

What was tested

Added a dummy function to cse_helpers.sh (maps to provisionSource)
Added a dummy function to ubuntu/cse_install_ubuntu.sh (maps to provisionInstallsUbuntu, expands to all distro variants)

Results (3 successful runs)

Run 1: Detected cse_helpers.sh → injected 1 write_files block (provisionSource) ✅
Run 2: Same detection after adding a real function (not just a comment) ✅
Run 3: Detected both scripts → injected 2 write_files blocks (provisionSource + distro group with 5 variants) ✅

Key observations

make generate produces no testdata diffs for script changes — Linux snapshot testdata was removed in PR fix: remove Linux snapshot test cases and testdata #8139
make generate is still useful as a validation step (shellcheck, components schema)
Script content is embedded via go:embed at compile time, not stored in intermediate files
The GH Action correctly uses Contents API + aks-node-assistant[bot] for signed commits
Distro expansion (provisionInstallsUbuntu → all 5 distro variants) works correctly

Commits on this branch

#	Author	Description
1	Developer	Test comment in cse_helpers.sh
2	aks-node-assistant[bot]	Auto-generated hotfix template (1 block)
3	Developer	Dummy function in cse_helpers.sh
4	aks-node-assistant[bot]	Auto-generated hotfix template (1 block)
5	Developer	Dummy function in cse_install_ubuntu.sh
6	aks-node-assistant[bot]	Auto-generated hotfix template (2 blocks)

This is a test PR — do not merge.

Add test comment to cse_helpers.sh to trigger hotfix template injection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Test PR intended to validate the hotfix-generate GitHub Action end-to-end by introducing a detectable change under parts/linux/cloud-init/artifacts/ (which should trigger regeneration/commit behavior).

Changes:

Added a test-only comment to cse_helpers.sh to trigger the workflow.

Copilot · 2026-03-20T23:29:36Z

parts/linux/cloud-init/artifacts/cse_helpers.sh

@@ -1,4 +1,5 @@
 #!/bin/bash
+# hotfix test: verify GH Action injects write_files block into nodecustomdata.yml


This comment is a test artifact (per PR description) and should be removed before merging to avoid leaving workflow/debug text in production provisioning scripts.

Suggested change

# hotfix test: verify GH Action injects write_files block into nodecustomdata.yml

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Copilot · 2026-03-20T23:46:58Z

parts/linux/cloud-init/artifacts/ubuntu/cse_install_ubuntu.sh

+hotfix_test_ubuntu_dummy() {
+    echo "dummy function for ubuntu hotfix testing"
+}
+


hotfix_test_ubuntu_dummy is test-only, unused code in a production provisioning script. If this accidentally merges it becomes part of the shipped CSE artifacts and increases the risk of future conflicts/maintenance overhead; please remove it (or keep workflow tests confined to non-shipping fixtures).

Suggested change

hotfix_test_ubuntu_dummy() {

echo "dummy function for ubuntu hotfix testing"

}

Copilot · 2026-03-20T23:46:59Z

parts/linux/cloud-init/nodecustomdata.yml

+# ---- hotfix: auto-generated by hotfix-generate GH Action ----
+- path: {{GetCSEHelpersScriptFilepath}}
+  permissions: "0744"
+  encoding: gzip
+  owner: root


This hotfix-generated write_files entry is placed inside the EnableScriptlessCSECmd branch, which explicitly documents that no cloud-init scripts should be written in scriptless mode. Adding {{GetCSEHelpersScriptFilepath}} here will re-introduce script content into custom data and will break the scriptless-mode invariant (there is an e2e assertion that custom data only contains scriptless-cse-overrides.txt). The injected block should be moved outside the scriptless branch (or gated by a separate hotfix flag) so scriptless custom data remains script-free.

Copilot · 2026-03-20T23:46:59Z

parts/linux/cloud-init/artifacts/cse_helpers.sh

+# hotfix test: verify GH Action injects write_files block into nodecustomdata.yml
 # ERR_SYSTEMCTL_ENABLE_FAIL=3 Service could not be enabled by systemctl -- DEPRECATED
+
+hotfix_test_dummy_function() {
+    local msg="this is a dummy function for hotfix testing"
+    echo "$msg"
+}


hotfix_test_dummy_function and the preceding test comment will ship to every node because cse_helpers.sh is a shared provisioning artifact that gets embedded into custom data. Since this is a test-only change, it should be removed (or confined to the workflow test harness) to avoid accumulating dead code in production bootstrap scripts.

Suggested change

# hotfix test: verify GH Action injects write_files block into nodecustomdata.yml

# ERR_SYSTEMCTL_ENABLE_FAIL=3 Service could not be enabled by systemctl -- DEPRECATED

hotfix_test_dummy_function() {

local msg="this is a dummy function for hotfix testing"

echo "$msg"

}

# ERR_SYSTEMCTL_ENABLE_FAIL=3 Service could not be enabled by systemctl -- DEPRECATED

test: verify hotfix-generate GH Action on official/v20260320

253236c

Add test comment to cse_helpers.sh to trigger hotfix template injection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Devinwong added the hotfix Only use this label when you are hot fixing an official release label Mar 20, 2026

Devinwong requested a review from cameronmeissner as a code owner March 20, 2026 23:27

Copilot AI review requested due to automatic review settings March 20, 2026 23:27

Devinwong requested review from AbelHu, awesomenix, calvin197, djsly, ganeshkumarashok, junjiezhang1997, lilypan26, mxj220, pdamianov-dev, phealy, r2k1, sulixu, surajssd, timmy-wright and zachary-bailey as code owners March 20, 2026 23:27

Devinwong temporarily deployed to test March 20, 2026 23:27 — with GitHub Actions Inactive

Devinwong temporarily deployed to test March 20, 2026 23:28 — with GitHub Actions Inactive

Copilot started reviewing on behalf of Devinwong March 20, 2026 23:28 View session

aks-node-assistant bot added 2 commits March 20, 2026 23:29

chore: auto-generate hotfix template entries

d006935

chore: auto-generate hotfix template entries

988a320

aks-node-assistant bot temporarily deployed to test March 20, 2026 23:29 Inactive

Copilot AI reviewed Mar 20, 2026

View reviewed changes

Devinwong changed the title ~~test: verify hotfix-generate GH Action on official/v20260320~~ [DO NOT review] test: verify hotfix-generate GH Action on official/v20260320 (no testdata diff case) Mar 20, 2026

test: add dummy function to cse_helpers.sh for hotfix testing

73a78e5

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Devinwong temporarily deployed to test March 20, 2026 23:38 — with GitHub Actions Inactive

test: add dummy function to cse_install_ubuntu.sh for hotfix testing

f9c2c50

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 20, 2026 23:43

Devinwong temporarily deployed to test March 20, 2026 23:43 — with GitHub Actions Inactive

Copilot started reviewing on behalf of Devinwong March 20, 2026 23:44 View session

chore: auto-generate hotfix template entries

d563ef9

aks-node-assistant bot temporarily deployed to test March 20, 2026 23:45 Inactive

Copilot AI reviewed Mar 20, 2026

View reviewed changes

Devinwong changed the title ~~[DO NOT review] test: verify hotfix-generate GH Action on official/v20260320 (no testdata diff case)~~ test: verify hotfix-generate GH Action on official/v20260320 Mar 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: verify hotfix-generate GH Action on official/v20260320#8147

test: verify hotfix-generate GH Action on official/v20260320#8147
Devinwong wants to merge 6 commits intoofficial/v20260320from
devinwon/hotfix-test-v20260320

Devinwong commented Mar 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1,4 +1,5 @@
		#!/bin/bash
		# hotfix test: verify GH Action injects write_files block into nodecustomdata.yml

	hotfix_test_ubuntu_dummy() {
	echo "dummy function for ubuntu hotfix testing"
	}

Conversation

Devinwong commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test PR for hotfix-generate GH Action

What was tested

Results (3 successful runs)

Key observations

Commits on this branch

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Devinwong commented Mar 20, 2026 •

edited

Loading