fix(windows-cse): check exit codes of external commands to honour try/catch

[timmy-wright]

Summary

Native executables in PowerShell set $LASTEXITCODE on failure but do not throw exceptions, so try/catch blocks silently swallow failures from commands like icacls.exe, sc.exe, nssm.exe, netsh, and reg.exe.

This PR adds if ($LASTEXITCODE -ne 0) { throw "..." } checks after each unchecked external command call so that failures propagate as exceptions through the call stack.

Changes

File	Commands fixed
parts/windows/kuberneteswindowssetup.ps1	icacls.exe (x4), netsh advfirewall
staging/cse/windows/configfunc.ps1	sc.exe failure (x3), reg.exe import in try/catch that did not catch it, icacls (x4), nssm.exe install+configure for csi-proxy and hosts-config-agent
staging/cse/windows/kubeletfunc.ps1	nssm.exe install+configure for Kubelet and Kubeproxy, Invoke-Expression nssm DependOnService
staging/cse/windows/containerdfunc.ps1	sc.exe delete, nssm.exe install+configure for containerd
staging/cse/windows/windowsciliumnetworkingfunc.ps1	Cilium install script invocation

Notes

• The reg.exe import call in configfunc.ps1 was already inside a try/catch but the catch was unreachable for native command failures. The $LASTEXITCODE check now makes it catchable.
• For nssm.exe blocks a check is added after install and after the final set call.
• Log/diagnostics-only commands were intentionally excluded.

Relates to IcM 613775405

[Copilot]

Pull request overview

This PR improves Windows CSE reliability by ensuring failures from native executables (which only set $LASTEXITCODE and don’t throw) are surfaced as exceptions so existing try/catch blocks can handle them, and it updates the generated CustomData snapshots accordingly.

Changes:

• Add $LASTEXITCODE checks after various sc.exe, reg.exe, icacls, netsh, and nssm.exe invocations and throw on non-zero exit codes.
• Ensure reg.exe import failures inside an existing try/catch become catchable.
• Regenerate/update pkg/agent/testdata/**/CustomData snapshots to reflect script changes.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
staging/cse/windows/windowsciliumnetworkingfunc.ps1	Throw on non-zero exit code after invoking the Windows Cilium install script.
staging/cse/windows/kubeletfunc.ps1	Add exit-code checks for nssm.exe install/configure and DependOnService operations.
staging/cse/windows/containerdfunc.ps1	Add exit-code checks for sc.exe delete and nssm.exe install/configure for containerd.
staging/cse/windows/configfunc.ps1	Add exit-code checks for sc.exe failure, reg.exe import, icacls, and nssm.exe service creation/configuration (csi-proxy, hosts-config-agent).
parts/windows/kuberneteswindowssetup.ps1	Add exit-code checks for icacls.exe ACL updates and netsh advfirewall disable.
pkg/agent/testdata/AKSWindows23H2Gen2+NextGenNetworkingNoConfig/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows23H2Gen2+NextGenNetworkingDisabled/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows23H2Gen2+NextGenNetworking/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+ootcredentialprovider/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+SecurityProfile/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+ManagedIdentity/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+KubeletServingCertificateRotation/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+KubeletClientTLSBootstrapping/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+K8S119/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+K8S119+FIPS/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+K8S119+CSI/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+K8S118/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+K8S117/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+K8S116/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+EnablePrivateClusterHostsConfigAgent/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+CustomVnet/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+CustomCloud/CustomData	Snapshot update to include new exit-code checks.
pkg/agent/testdata/AKSWindows2019+CustomCloud+ootcredentialprovider/CustomData	Snapshot update to include new exit-code checks.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.