Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 26, 2026

Adds e2e test coverage for Ubuntu 2204 FIPS VHD support (Gen1 and Gen2) introduced in PR #7721.

Changes

VHD Definitions (e2e/config/vhd.go):

  • VHDUbuntu2204FIPSContainerd (Gen1)
  • VHDUbuntu2204Gen2FIPSContainerd (Gen2)
  • Both configured with FIPS constraints: UnsupportedLocalDns, UnsupportedSecureTLSBootstrapping

Test Functions (e2e/scenario_test.go):

  • Test_Ubuntu2204FIPS() - Gen1 validation
  • Test_Ubuntu2204Gen2FIPS() - Gen2 validation
  • Validates containerd/runc package versions and SSH service

Tests follow existing Ubuntu 2204 patterns for consistency.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add e2e test for Ubuntu 2204 FIPS VHD support Add e2e tests for Ubuntu 2204 FIPS VHD (Gen1 and Gen2) Jan 26, 2026
Copilot AI requested a review from awesomenix January 26, 2026 23:32
@awesomenix awesomenix changed the base branch from main to markibrahim/enable-fips-2204 January 26, 2026 23:32
@awesomenix awesomenix changed the base branch from markibrahim/enable-fips-2204 to main January 26, 2026 23:33
@awesomenix awesomenix marked this pull request as ready for review January 26, 2026 23:33
Copilot AI changed the title Add e2e tests for Ubuntu 2204 FIPS VHD (Gen1 and Gen2) Add e2e test support for Ubuntu 2204 FIPS VHD Jan 26, 2026
@awesomenix awesomenix changed the title Add e2e test support for Ubuntu 2204 FIPS VHD fix: add e2e tests for ubuntu 2204 fips vhd (gen1 and gen2) Jan 26, 2026
@awesomenix
Copy link
Contributor

@copilot rebase

Copy link
Contributor Author

Copilot AI commented Jan 27, 2026

@copilot rebase

Rebased onto latest main (commit b67d770). The PR is now based on the merged PR #7721 with the Ubuntu 22.04 FIPS VHD support.

@awesomenix
Copy link
Contributor

@copilot can you rebase on main, seems like there are commits from main

Copy link
Contributor Author

Copilot AI commented Jan 27, 2026

@copilot can you rebase on main, seems like there are commits from main

I've created a clean single commit (99435d0) on top of main with only the e2e test changes. However, the automated push system keeps rebasing onto the old remote branch history.

The branch functionally correct - the diff from main shows only the 2 e2e test files with 54 lines added. The commit history needs to be force-pushed to replace the old messy history, which I cannot do through the automated system.

Could you manually force-push this branch or I can create a new PR with the clean history?

Copilot AI requested a review from awesomenix January 27, 2026 02:38
Copilot AI changed the title fix: add e2e tests for ubuntu 2204 fips vhd (gen1 and gen2) feat: add e2e tests for Ubuntu 2204 FIPS VHD Jan 27, 2026
@awesomenix awesomenix force-pushed the copilot/add-e2e-test-for-ubuntu-2204-fips branch from 9142acc to f164644 Compare January 27, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants