feat: node-exporter into vhd build #7704
Open
+9,686
−9,117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: aks-node-assistant[bot] <190555641+aks-node-assistant[bot]@users.noreply.github.com>
Co-authored-by: Cameron Meissner <cameronmeissner@gmail.com>
Co-authored-by: aks-node-assistant[bot] <190555641+aks-node-assistant[bot]@users.noreply.github.com>
…source in scenario Flatcar_SecureTLSBootstrapping_BootstrapToken_Fallback (#7495)
Co-authored-by: aks-node-assistant[bot] <190555641+aks-node-assistant[bot]@users.noreply.github.com>
#7521) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: aks-node-assistant[bot] <190555641+aks-node-assistant[bot]@users.noreply.github.com>
Co-authored-by: aks-node-assistant[bot] <190555641+aks-node-assistant[bot]@users.noreply.github.com>
Co-authored-by: aks-node-assistant[bot] <190555641+aks-node-assistant[bot]@users.noreply.github.com>
…15-7 (#7577) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Cameron Meissner <cameronmeissner@gmail.com>
chmill-zz
requested review from
AbelHu,
Devinwong,
awesomenix,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
chmill-zz
force-pushed
the
nodeexportershift
branch
from
0d52887 to
60cc001
Compare
github-actions
bot
added
the
components
chmill-zz
force-pushed
the
nodeexportershift
branch
from
f0f23e8 to
eb8e316
Compare
The wait -n command in the image pull loop was catching ANY background job exit, including the BCC installation subshell. When BCC's apt_get_update failed (exit code 99), it was incorrectly reported as an image pull failure. This fix changes the parallel execution logic to: - Track only image_pids array length instead of all jobs - Use kill -0 to check if specific image PIDs are still running - Use wait $pid to get exit status of specific processes This isolates BCC failures to be handled at their designated wait point (line 809) rather than in the image pull error handling loop.
chmill-zz
force-pushed
the
nodeexportershift
branch
from
c8871d0 to
68a2704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
this is adding node-exporter into the vhdbuild by default. At the end of the vhdbuild we systemctl disable to allow a fresh start during cse letting the node-exporter-startup script run and gather up node specific details needed.
Which issue(s) this PR fixes:
Fixes #