Skip to content

feat: add EnableManagedGPU NBC variable for managed GPU experience #7672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
calvin197 wants to merge 27 commits into
base: main
Choose a base branch
from
Open

feat: add EnableManagedGPU NBC variable for managed GPU experience #7672

calvin197 wants to merge 27 commits into from

Conversation

@calvin197
Copy link
Contributor

@calvin197 calvin197 commented Jan 16, 2026 •
edited
Loading

What this PR does / why we need it:
Add EnableManagedGPU bool to NBC for enabling managed GPU experience.

  • Adds field to proto, datamodel, baker, and parser
  • Updates enableManagedGPUExperience() to check NBC var first, then fall back to VMSS tag
  • OR logic: if either is true, feature is enabled
  • also made some small refactor to existing managed gpu logic

Which issue(s) this PR fixes:

Fixes #

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 22, 2026, 12:35 AM

@calvin197 calvin197 changed the title feat: Add nvidiaManagementMode NBC variable for managed GPU experience feat: add nvidiaManagementMode NBC variable for managed GPU experience Jan 16, 2026
@calvin197 calvin197 changed the title feat: add nvidiaManagementMode NBC variable for managed GPU experience feat: add EnableManagedGPU NBC variable for managed GPU experience Jan 20, 2026
lilypan26
lilypan26 reviewed Jan 21, 2026
View reviewed changes
@lilypan26
Copy link
Contributor

lilypan26 commented Jan 21, 2026

can you fix the shelspec tests? seems some are failing

@ganeshkumarashok
Copy link
Contributor

ganeshkumarashok commented Jan 21, 2026

Were Agentbaker e2es for GPU tests run? Seems like they were skipped?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ganeshkumarashok ganeshkumarashok ganeshkumarashok approved these changes

@lilypan26 lilypan26 lilypan26 approved these changes

@yewmsft yewmsft Awaiting requested review from yewmsft yewmsft is a code owner

@YaoC YaoC Awaiting requested review from YaoC YaoC is a code owner

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@cameronmeissner cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@AbelHu AbelHu Awaiting requested review from AbelHu AbelHu is a code owner

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

@djsly djsly Awaiting requested review from djsly djsly is a code owner

@phealy phealy Awaiting requested review from phealy phealy is a code owner

@r2k1 r2k1 Awaiting requested review from r2k1 r2k1 is a code owner

@timmy-wright timmy-wright Awaiting requested review from timmy-wright timmy-wright is a code owner

@zachary-bailey zachary-bailey Awaiting requested review from zachary-bailey zachary-bailey is a code owner

@awesomenix awesomenix Awaiting requested review from awesomenix awesomenix is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@calvin197 @lilypan26 @ganeshkumarashok