fix: stage release downloads outside target folder so failures don't leave empty dirs#534
Merged
jaredfholgate merged 2 commits intomainfrom Apr 30, 2026
Merged
Conversation
Get-GithubRelease now downloads and extracts release artifacts into a per-invocation guid folder under <outputs>/temp/downloads, and only creates the release/version target folders after the download and extract succeed. The staging folder is always cleaned up via finally, so a failed bootstrap or starter download no longer leaves empty release folders behind. Also adds a configurable terraform_version parameter to Deploy-Accelerator (default 1.14.9) instead of always using latest.
github-project-automation
Bot
moved this to To triage
in Azure Landing Zone Issues & PRs Triage
jtracey93
previously approved these changes
Apr 30, 2026
…version The specific-version branch of Get-TerraformTool assigned the raw JSON string to $release instead of parsing it, causing the builds lookup to return an empty download URL.
jtracey93
approved these changes
Apr 30, 2026
github-project-automation
Bot
moved this from To triage
to Done
in Azure Landing Zone Issues & PRs Triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If a bootstrap or starter release download/extract fails partway through,
Get-GithubReleasepreviously left behind empty release/version folders inside the outputs directory. On a subsequent run, the folder existed (but was empty), which could confuse theTest-Path+ content checks downstream.Changes
src/ALZ/Private/Shared/Get-GithubRelease.ps1: download + extract now happen in a per-invocation guid folder under<outputs>/temp/downloads/<guid>. The releaseand per-versionfolders are only created after both the download andExpand-Archivesucceed, immediately before copying content in. The staging folder is always cleaned up viafinally.src/ALZ/Public/Deploy-Accelerator.ps1: adds a configurableterraform_versionparameter (default1.14.9) instead of always pullinglatest.Behaviour