Skip to content

Add azd-service-name tag to function app parameters#15

Closed
vhvb1989 wants to merge 1 commit intoAzure-Samples:mainfrom
vhvb1989:patch-1
Closed

Add azd-service-name tag to function app parameters#15
vhvb1989 wants to merge 1 commit intoAzure-Samples:mainfrom
vhvb1989:patch-1

Conversation

@vhvb1989
Copy link
Copy Markdown

Missing tag for azd to know where to deploy

Missing tag for azd to know where to deploy
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to ensure Azure Developer CLI (azd) can correctly identify the Function App service to deploy by adding an azd-service-name tag to the API Function App module parameters.

Changes:

  • Update the api module parameters in infra/main.bicep to include the azd-service-name: api tag via union(...).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/main.bicep
Comment on lines +109 to +111
tags: union(tags, {
'azd-service-name': 'api'
})
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra/app/api.bicep already applies the azd-service-name tag to the Function App resource (tags: union(tags, { 'azd-service-name': serviceName })). Adding the same tag again here makes the source of truth unclear and can drift if serviceName is ever overridden. Consider either (a) reverting to tags: tags here and relying on api.bicep, or (b) passing an explicit serviceName param from main.bicep and letting api.bicep set the tag once.

Suggested change
tags: union(tags, {
'azd-service-name': 'api'
})
tags: tags

Copilot uses AI. Check for mistakes.
@paulyuk
Copy link
Copy Markdown
Collaborator

paulyuk commented Feb 25, 2026

Good idea, already solved in a deeper file. thank you!

@paulyuk paulyuk closed this Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants