Skip to content

test(e2e): fix expiration_timestamp prune race + flake-group e2e_slashing #23432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AztecBot wants to merge 2 commits into
base: merge-train/spartan
Choose a base branch
from
Open

test(e2e): fix expiration_timestamp prune race + flake-group e2e_slashing #23432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab7ed7a
test: flake-group e2e_slashing + e2e_expiration_timestamp race
AztecBot May 20, 2026
1142f6c
test(e2e): cache header in e2e_expiration_timestamp to avoid prune race
AztecBot May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .test_patterns.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,11 @@ tests:
owners:
- *palla

- regex: "src/e2e_slashing/.*\\.test\\.ts"
flake_group_id: e2e-p2p-epoch-flakes
owners:
- *palla

- regex: "p2p/src/client/test/.*\\.test\\.ts"
flake_group_id: e2e-p2p-epoch-flakes
owners:
Expand Down
15 changes: 9 additions & 6 deletions yarn-project/end-to-end/src/e2e_expiration_timestamp.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,23 @@ describe('e2e_expiration_timestamp', () => {

describe('when requesting expiration timestamp lower than the next block', () => {
let expirationTimestamp: bigint;
let latestBlockTimestamp: bigint;

beforeEach(async () => {
// The prior test's `cheatCodes.eth.warp` can invalidate a pipelined block (the proposer
// builds N+1 during slot N, but L1 jumped past slot N+1's deadline). The archiver then
// prunes that block asynchronously, opening a race where `getBlockData('latest')`
// resolves a block number that's deleted by the time the row is read. We cache the
// timestamp here so `runInvalidatesTest` doesn't need a second read mid-cycle.
const header = (await aztecNode.getBlockData('latest'))?.header;
if (!header) {
throw new Error('Block header not found in the setup of e2e_expiration_timestamp.test.ts');
}
latestBlockTimestamp = header.globalVariables.timestamp;
// 1n lower than two slots ahead. Under proposer pipelining the anchor block may already
// have advanced one slot past the latest mined header, so the next slot to be mined is
// typically two slots ahead; this expiration sits just below that slot's start.
expirationTimestamp = header.globalVariables.timestamp + aztecSlotDuration * 2n - 1n;
expirationTimestamp = latestBlockTimestamp + aztecSlotDuration * 2n - 1n;
});

describe('with no enqueued public calls', () => {
Expand Down Expand Up @@ -142,11 +149,7 @@ describe('e2e_expiration_timestamp', () => {
// L1 time past the expiration. Submitting the proven tx must then be rejected by the node because
// the next slot's timestamp (derived from L1 time) is greater than the tx expiration.
async function runInvalidatesTest(enqueuePublicCall: boolean) {
const header = (await aztecNode.getBlockData('latest'))?.header;
if (!header) {
throw new Error('Block header not found in invalidates-the-transaction setup');
}
const requestedExpiration = header.globalVariables.timestamp + aztecSlotDuration * 5n;
const requestedExpiration = latestBlockTimestamp + aztecSlotDuration * 5n;

const provenTx = await proveInteraction(
wallet,
Expand Down
Loading