chore: remove release-please workflow and configs (backport #23401)#23430
Draft
AztecBot wants to merge 1 commit into
Draft
chore: remove release-please workflow and configs (backport #23401)#23430AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Conservative pass on `next` — keeps `.release-please-manifest.json` (still used as the version source by `bootstrap.sh`, workflows, `ci3/source_refname`, playground, telemetry, pxe, spartan scripts, release-image Docker, etc.) and removes only the release-please tooling and stale doc references. - `.github/workflows/release-please.yml` — the googleapis/release-please-action workflow - `.github/release-please-master.json`, `-v2.json`, `-v3.json`, `-v4.json` — release-please configs - The `x-release-please-*` magic-comment blocks in both Docusaurus configs (these were release-please tool markers) - `README.md` Releases paragraph — points at tags + manifest instead of release-please - `bootstrap.sh` comment — drop "release-please creates it" aside - `docs/scripts/cli_reference_generation/CLI_DOCS_README.md` — drop dead `release-please.yml` reference - `spartan/testnet-runbook.md` — describe tag-driven release instead of "initiate a release-please workflow" - `.claude/skills/merge-train-infra` — describe `BEGIN/END_COMMIT_OVERRIDE` markers without claiming they're consumed by release-please - `yarn-project/BRANCHING.md` — fix one dead link to `release-please.yml`; the rest of BRANCHING.md (including v2's still-active release-please description and all `.release-please-manifest.json` references) is left alone - `.release-please-manifest.json` — kept as the canonical version source - `create-release-branch.yml` — still bumps `.release-please-manifest.json` (manifest stays) - All workflows / bash / TS / JS that read the manifest — all unchanged - `docs/README.md` macro paragraph naming the manifest — still accurate - `.claude/skills/updating-changelog` — still tells you to read the manifest - `.claude/skills/noir-sync-update` — references the noir submodule's own manifest, out of scope - v2's release-please description in `BRANCHING.md` — `v2` still has release-please; only `next` changes - `v4-next` — companion PR #23402 closed; only `next` per request 13 files changed, 6 insertions(+), 436 deletions(-). - [ ] CI green (no consumer touched, no version-resolution path changed) - [ ] release-image build still stamps `.release-please-manifest.json` and `aztec --version` is correct
AztecBot
added
ci-draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #23401 to
v4-next(via thebackport-to-v4-next-stagingstaging branch).Removes the release-please workflow (
.github/workflows/release-please.yml) and its per-version configs (.github/release-please-{master,v2,v3,v4}.json), and clears the correspondingx-release-please-*magic-comment blocks and stale release-please references from docs / bootstrap / runbooks.The
.release-please-manifest.jsonis intentionally kept — it remains the canonical version source consumed bybootstrap.sh, workflows,ci3/source_refname, playground, telemetry, pxe, spartan scripts, and the release-image Docker build.Conflicts resolved
bootstrap.sh— v4-next has a slightly different leading comment inrelease()("Our releases are controlled by the REF_NAME environment variable..." vsnext's newer wording). Preserved the v4-next wording and only removed the", if not on latest (in which case release-please creates it)"trailing clause, matching the PR's intent onnext..claude/skills/merge-train-infra/SKILL.md— v4-next doesn't yet describe thebackport-to-*-stagingintegration ofmerge-train-update-pr-body.yml. Kept the v4-next wording and only swapped theBEGIN_COMMIT_OVERRIDE/END_COMMIT_OVERRIDEblurb from "markers for release-please" → "wraps the commit list in ... markers", matching the PR's intent.No code path consuming the manifest was touched, so no build/test changes are expected from this backport.
ClaudeBox log: https://claudebox.work/s/af14c48b1c6ee2d7?run=1