refactor: move validation and error handling out of transport layer#23422
Merged
Conversation
nchamo
force-pushed
the
nchamo/lean-transport-layer
branch
from
952b906 to
4d3378e
Compare
nchamo
changed the title
…/lean-transport-layer # Conflicts: # yarn-project/txe/src/rpc_translator.ts
mverzilli
reviewed
May 21, 2026
mverzilli
reviewed
May 21, 2026
mverzilli
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why we are doing this
rpc_translator.tsandoracle.tswere mixing serialization/deserialization with validation, error handling, and orchestration logic, making it hard to reason about and difficult to auto-generate in the future.Our fix
Validation, null checks, bounds enforcement, forbidden-operation throws, and the version compatibility check have all moved into the handler layer:
getNoteHashMembershipWitness,getNullifierMembershipWitness,getLowNullifierMembershipWitness,getPublicDataWitness,getBlockHeader,getAuthWitness) — handlers now return non-optional values and throw when the lookup fails.TXEPrivateExecutionOracle,TXEOraclePublicContext) by overriding methods to throw; the transport calls the handler without knowing the difference.MAX_PRIVATE_LOGS_PER_TX, offchain-effects length) moved into handlers.Buffer | undefined; transport no longer catches).TXESession.setTxeOracleVersion().MAX_OFFCHAIN_EFFECTS_PER_TXE_QUERYandMAX_OFFCHAIN_EFFECT_LENmoved fromtxe_oracle_version.tstotxe_session.ts, co-located with the validation that uses them.The transport is now pure serialize → delegate → deserialize. No behavior change.