feat(aztec-nr): add Serialize/Deserialize for EphemeralArray#23417
Open
nchamo wants to merge 2 commits into
Open
feat(aztec-nr): add Serialize/Deserialize for EphemeralArray#23417nchamo wants to merge 2 commits into
nchamo wants to merge 2 commits into
Conversation
mverzilli
reviewed
May 21, 2026
| impl<T> Serialize for EphemeralArray<T> { | ||
| let N: u32 = 1; | ||
|
|
||
| fn serialize(self) -> [Field; 1] { |
Contributor
There was a problem hiding this comment.
This signature should be [Field; N], correct?
(or, if the N assignment in line 108 can be deleted, that would be equally good I guess)
mverzilli
reviewed
May 21, 2026
| pub(crate) unconstrained fn get_pending_tagged_logs(scope: AztecAddress) -> EphemeralArray<PendingTaggedLog> { | ||
| let result_slot = get_pending_tagged_logs_oracle(scope); | ||
| EphemeralArray::at(result_slot) | ||
| get_pending_tagged_logs_oracle(scope) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SerializeandDeserializetrait implementations toEphemeralArray<T>, serializing as a singleField(the slot identifier).message_processing.nrandshared_secret.nrto accept and returnEphemeralArray<T>directly instead of opaque rawFieldslots, eliminating manualEphemeralArray::at(slot)wrapping at every call site.