Skip to content

fix: cap deserialization vector/map sizes at 256 MB to prevent OOM DoS #22283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnathan79717 wants to merge 1 commit into
base: merge-train/barretenberg
Choose a base branch
from
+17 −0
Open

fix: cap deserialization vector/map sizes at 256 MB to prevent OOM DoS #22283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions barretenberg/cpp/src/barretenberg/common/serialize.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include "barretenberg/common/log.hpp"
#include "barretenberg/common/mem.hpp"
#include "barretenberg/common/net.hpp"
#include "barretenberg/common/throw_or_abort.hpp"
#include "barretenberg/serialize/msgpack_apply.hpp"
#include <array>
#include <cassert>
Expand All @@ -41,6 +42,10 @@
#include <type_traits>
#include <vector>

// Maximum total bytes a single deserialization may allocate (256 MB).
// Prevents attacker-controlled size fields from triggering multi-GB allocations.
inline constexpr size_t MAX_SERIALIZE_BYTES = 256ULL * 1024 * 1024;

#ifndef __i386__
__extension__ using uint128_t = unsigned __int128;
#endif
Expand Down Expand Up @@ -215,6 +220,9 @@ inline void read(uint8_t const*& it, std::vector<uint8_t>& value)
{
uint32_t size = 0;
read(it, size);
if (size > MAX_SERIALIZE_BYTES) {
throw_or_abort("deserialize: vector<uint8_t> size exceeds 256 MB limit");
}
value.resize(size);
std::copy(it, it + size, value.data());
it += size;
Expand All @@ -233,6 +241,9 @@ inline void read(std::istream& is, std::vector<uint8_t>& value)
{
uint32_t size = 0;
read(is, size);
if (size > MAX_SERIALIZE_BYTES) {
throw_or_abort("deserialize: vector<uint8_t> size exceeds 256 MB limit");
}
value.resize(size);
is.read(reinterpret_cast<char*>(value.data()), static_cast<std::streamsize>(size));
}
Expand Down Expand Up @@ -282,6 +293,9 @@ template <typename B, typename T, typename A> inline void read(B& it, std::vecto
using serialize::read;
uint32_t size = 0;
read(it, size);
if (static_cast<uint64_t>(size) * sizeof(T) > MAX_SERIALIZE_BYTES) {
throw_or_abort("deserialize: vector size exceeds 256 MB limit");
}
value.resize(size);
for (size_t i = 0; i < size; ++i) {
read(it, value[i]);
Expand Down Expand Up @@ -353,6 +367,9 @@ template <typename B, typename T, typename U> inline void read(B& it, std::map<T
value.clear();
uint32_t size = 0;
read(it, size);
if (static_cast<uint64_t>(size) * (sizeof(T) + sizeof(U)) > MAX_SERIALIZE_BYTES) {
throw_or_abort("deserialize: map size exceeds 256 MB limit");
}
for (size_t i = 0; i < size; ++i) {
std::pair<T, U> v;
read(it, v);
Expand Down
Loading