Skip to content

fix: cap decompress() buffer at 256 MB to prevent zip bomb OOM #22277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnathan79717 wants to merge 1 commit into
base: merge-train/barretenberg
Choose a base branch
from
+6 −2
Open

fix: cap decompress() buffer at 256 MB to prevent zip bomb OOM #22277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions barretenberg/cpp/src/barretenberg/chonk/private_execution_steps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ std::vector<uint8_t> compress(const std::vector<uint8_t>& input)
*/
std::vector<uint8_t> decompress(const void* bytes, size_t size)
{
static constexpr size_t MAX_DECOMPRESSED_SIZE = 256ULL * 1024 * 1024; // 256 MB
std::vector<uint8_t> content;
// initial size guess
content.resize(1024ULL * 128ULL);
Expand All @@ -53,8 +54,11 @@ std::vector<uint8_t> decompress(const void* bytes, size_t size)
libdeflate_result decompress_result =
libdeflate_gzip_decompress(decompressor.get(), bytes, size, content.data(), content.size(), &actual_size);
if (decompress_result == LIBDEFLATE_INSUFFICIENT_SPACE) {
// need a bigger buffer
content.resize(content.size() * 2);
size_t new_size = content.size() * 2;
if (new_size > MAX_DECOMPRESSED_SIZE) {
THROW std::runtime_error("decompressed size exceeds 256 MB limit");
}
content.resize(new_size);
continue;
}
if (decompress_result == LIBDEFLATE_BAD_DATA) {
Expand Down
Loading