Skip to content

fix: catch exceptions in ChonkBatchVerifier::batch_check #22273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AztecBot wants to merge 1 commit into
base: merge-train/barretenberg
Choose a base branch
from
+8 −2
Draft

fix: catch exceptions in ChonkBatchVerifier::batch_check #22273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions barretenberg/cpp/src/barretenberg/chonk/chonk_batch_verifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,14 @@ bool ChonkBatchVerifier::batch_check(const std::vector<ReduceResult>& results, c
transcripts.push_back(std::make_shared<NativeTranscript>(results[idx].ipa_proof));
}

auto ipa_vk = VerifierCommitmentKey<curve::Grumpkin>{ ECCVMFlavor::ECCVM_FIXED_SIZE };
return IPA<curve::Grumpkin>::batch_reduce_verify(ipa_vk, claims, transcripts);
try {
auto ipa_vk = VerifierCommitmentKey<curve::Grumpkin>{ ECCVMFlavor::ECCVM_FIXED_SIZE };
return IPA<curve::Grumpkin>::batch_reduce_verify(ipa_vk, claims, transcripts);
} catch (...) {
// Corrupted proofs can cause deserialization errors (e.g. "point not on curve").
// Treat any exception as a batch failure so bisection can isolate the bad proof(s).
return false;
}
}

void ChonkBatchVerifier::bisect(std::vector<ReduceResult>& results,
Expand Down
Loading