Open
Conversation
Fixing a rare edge case caused by a bug in radix sort recursive calls
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
…op archiver pollution (#22183) — WITH CONFLICTS
- .gitignore: removed ignition-fisherman.env entry (PR intent was to delete it) - devnet-avm-prover.env, ignition-fisherman.env: deleted (already removed on next) - mainnet.env: kept deleted (doesn't exist on v4-next) - checkpoint_proposal_job.ts: merged both conditions (kept !== false from v4-next + added fishermanMode check from PR)
Collaborator
Author
|
🤖 Auto-merge enabled after 8 hours of inactivity. This PR will be merged automatically once all checks pass. |
…ollution (backport #22183) (#22284) ## Summary Backport of #22183 to v4-next. **Code fix** (`checkpoint_proposal_job.ts`): `syncProposedBlockToArchiver` now skips the archiver push when `fishermanMode` is `true`, preventing spurious reorg cascades on mainnet. **Infrastructure split** (`main.tf`, `variables.tf`, `deploy_network.sh`): Replaces `FISHERMAN_MODE` with `FISHERMAN_REPLICAS` and adds a dedicated `fisherman` Helm release as a separate StatefulSet. ## Conflicts resolved - `spartan/.gitignore`: Removed `ignition-fisherman.env` entry (PR intent was to delete it; `block-capacity.env` doesn't exist on v4-next) - `spartan/environments/devnet-avm-prover.env`, `ignition-fisherman.env`: Deleted (modify/delete — PR deletes, v4-next had modifications) - `spartan/environments/mainnet.env`: Kept deleted (doesn't exist on v4-next) - `checkpoint_proposal_job.ts`: Merged v4-next's `!== false` condition with PR's `|| this.config.fishermanMode` addition ClaudeBox log: https://claudebox.work/s/b82065b06bcc585b?run=1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: pippenger edge case (#22256)
END_COMMIT_OVERRIDE