Skip to content

chore: fix inconsistent usage of contract class hash fn #22248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nventuro wants to merge 1 commit into
base: merge-train/fairies
Choose a base branch
from
Open

chore: fix inconsistent usage of contract class hash fn #22248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions noir-projects/aztec-nr/aztec/src/context/private_context.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ use crate::protocol::{
MAX_PRIVATE_CALL_STACK_LENGTH_PER_CALL, MAX_PRIVATE_LOGS_PER_CALL, MAX_TX_LIFETIME,
NULL_MSG_SENDER_CONTRACT_ADDRESS, PRIVATE_LOG_CIPHERTEXT_LEN,
},
hash::poseidon2_hash,
hash::compute_contract_class_log_hash,
messaging::l2_to_l1_message::L2ToL1Message,
side_effect::{Counted, scoped::Scoped},
traits::{Empty, Hash, ToField},
Expand Down Expand Up @@ -942,6 +942,13 @@ impl PrivateContext {
self.private_logs.push(private_log.count(counter));
}

/// Emits large data blobs.
///
/// This reuses the Contract Class Log channel to emit blobs of up to [`CONTRACT_CLASS_LOG_SIZE_IN_FIELDS`].
///
/// ## Privacy
///
/// The address of the contract emitting these blobs is revelead.
pub fn emit_contract_class_log<let N: u32>(&mut self, log: [Field; N]) {
let contract_address = self.this_address();
let counter = self.next_counter();
Expand All @@ -953,10 +960,10 @@ impl PrivateContext {
// Safety: The below length is constrained in the base rollup, which will make sure that all the fields beyond
// length are zero. However, it won't be able to check that we didn't add extra padding (trailing zeroes) or
// that we cut trailing zeroes from the end.
let length = unsafe { trimmed_array_length_hint(log_to_emit) };
let length = unsafe { trimmed_array_length_hint(log) };
// We hash the entire padded log to ensure a user cannot pass a shorter length and so emit incorrect shorter
// bytecode.
let log_hash = poseidon2_hash(log_to_emit);
let log_hash = compute_contract_class_log_hash(log_to_emit);
// Safety: the below only exists to broadcast the raw log, so we can provide it to the base rollup later to be
// constrained.
unsafe {
Expand Down
Loading