Skip to content

chore: (A-750) read JSON body then parse to avoid double stream consumption on error message #22247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielntmd wants to merge 1 commit into
base: merge-train/spartan
Choose a base branch
from
Open

chore: (A-750) read JSON body then parse to avoid double stream consumption on error message #22247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions yarn-project/foundation/src/json-rpc/client/undici.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,20 @@ export function makeUndiciFetch(client = new Agent()): JsonRpcFetch {
let responseJson: any;
const responseOk = resp.statusCode >= 200 && resp.statusCode <= 299;
const contentEncoding = resp.headers['content-encoding'];
let responseText: string;
try {
if (contentEncoding === 'gzip') {
const jsonBuffer = await gunzip(await resp.body.arrayBuffer());
responseJson = JSON.parse(jsonBuffer.toString('utf-8'));
responseText = jsonBuffer.toString('utf-8');
} else {
responseJson = await resp.body.json();
responseText = await resp.body.text();
}
responseJson = JSON.parse(responseText);
} catch {
if (!responseOk) {
throw new Error('HTTP ' + resp.statusCode);
}
throw new Error(`Failed to parse body as JSON. encoding: ${contentEncoding}, body: ${await resp.body.text()}`);
throw new Error(`Failed to parse body as JSON. encoding: ${contentEncoding}, body: ${responseText!}`);
}

if (!responseOk) {
Expand Down
Loading