chore: improve note_getter performance on >1 notes#20508
Merged
Conversation
benesjan
approved these changes
Feb 16, 2026
Contributor
benesjan
left a comment
benesjan
left a comment
There was a problem hiding this comment.
LGTM
I have some questions:
- Do you understand why Noir messes this up when we use a normal constant for
options.limitbut it doesn't mess it up when a numeric type parameter is used? Both are a thing that is determined at comptime so this is very strange to me. - Can you think of a legitimate use of RAM in our codebase? Would it be reasonable to just have Noir error out when RAM is used? Feels like whenever we use RAM it's a bug.
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation in the source code.
I've not run our own benchmarks on this yet, but a benchmark from externals reported a decrease from 140k gates to 90k when running a simple contract that read 8 notes, and 260k to 160k with 16 notes. We should see similar results in our own setup.
edit: alternative explanation from Slack, in case anyone finds it useful: