docs: DO NOT MERGE Mc/audit comments #19236
Open
+2,527
−210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just pushing my unfinished, WIP, disorganised review comments before Xmas.
Mainly for @LeilaWang to take a look at whenever you return to work :)
Noteworthy things:
Q:,TODO:,AUDIT_COMMENT:comments littered through the code as I read.ABOUT.mdfile, which summarises what all the rollup circuits do, and will hopefully be useful to external auditors (and will be useful to me whenever I return back to the rollup circuits).