Skip to content

Conversation

@just-mitch
Copy link
Collaborator

@just-mitch just-mitch commented Dec 23, 2025

Make Fee Asset Handler Optional in L1FeeJuicePortalManager

This PR modifies the L1FeeJuicePortalManager to make the fee asset handler address optional. The handler is only needed for minting tokens during testing, so this change allows the manager to be created without requiring a handler address.

Key changes:

  • Updated the constructor to accept handlerAddress as EthAddress | undefined
  • Modified the create method to make the handler optional when creating a new manager
  • Removed the error thrown when handler address is zero or undefined
  • Optimized the token amount calculation in bridgeTokensPublic method

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@just-mitch just-mitch marked this pull request as ready for review December 23, 2025 17:18
@AztecBot
Copy link
Collaborator

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (\0338;;http://ci.aztec-labs.com/e67a83d29eb0b2c4�e67a83d29eb0b2c48;;�\033):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/multiple_validators_sentinel.parallel.test.ts "collects attestations for validators in proposer node when block is not published" (124s) (code: 1) group:e2e-p2p-epoch-flakes (\033Mitchell Tracy\033: fix: make fee asset handler optional for L1TokenManager)

Copy link
Contributor

@alejoamiras alejoamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the codeowner; but in case there is a need for an approval: this looks good to me, and tests are passing, so it looks safe. In order to get the fix, we'd need to backport it to devnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants