refactor(PXE): sync from PXE instead of from contracts #19193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 16, 2025 15:48
added 17 commits
December 19, 2025 16:20
mverzilli
added
the
ci-no-fail-fast
AztecBot
force-pushed
the
martin/refactor-pxe-oracle-interface-away
branch
2 times, most recently
from
237ef24 to
1c4f126
Compare
Base automatically changed from
martin/refactor-pxe-oracle-interface-away
to
next
December 22, 2025 17:18
mverzilli
commented
Dec 22, 2025
Comment on lines
-123
to
-126
| // All private functions perform message discovery, since they may need to access notes. This is slightly | ||
| // inefficient and could be improved by only doing it once we actually attempt to read any. Note that the message | ||
| // discovery call syncs private events as well. We do not sync those here if there are no notes because we don't | ||
| // have an API that would access events from private functions. |
Contributor
Author
There was a problem hiding this comment.
TODO: check that we're fine not handling this case with this new implementation
Contributor
Author
There was a problem hiding this comment.
Checked: this is indeed an optimization, if the contract doesn't have any notes, discovery isn't necessary. We should discuss if it's worth keeping it now that we control this process from TS world
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the responsibility of deciding when to trigger a contract sync from Aztec.nr to PXE.
sync_private_statefrom PXE at a few key points: before running a private function, before running a nested private function, before running a utility functionsync_private_statefrom being invoke unless it's from PXE itself, to ensure consistent and controlled synchronizationCloses F-162