feat: ValidatorKeystore implementation for high-availability signer #19094
+1,188
−288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
spypsy
force-pushed
the
spy/ha-keystore
branch
from
ab1a508 to
662e326
Compare
spypsy
requested review from
a team,
IlyasRidhuan,
LHerskind,
LeilaWang,
Maddiaa0,
charlielye,
dbanks12,
fcarreiro,
jeanmon,
just-mitch and
sirasistant
as code owners
spypsy
force-pushed
the
spy/ha-keystore
branch
from
662e326 to
9c10b83
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
spypsy
removed request for
IlyasRidhuan,
LHerskind,
LeilaWang,
Maddiaa0,
charlielye,
dbanks12,
fcarreiro,
jeanmon,
just-mitch and
sirasistant
AztecBot
force-pushed
the
spy/ha-keystore
branch
from
d716b2c to
1882379
Compare
Fixes [A-354](https://linear.app/aztec-labs/issue/A-354/integrate-slash-protection-in-signing-path) Implements `ExtendedValidatorKeyStore` utilizing `ValidatorHASigner`. Updated interfaces to return `null` when the signature isn't acquired & updated handling of signing for `null` results. Also some cleanup on previous HA work like consolidating config
AztecBot
force-pushed
the
spy/ha-keystore
branch
from
1882379 to
7e10af7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes A-354
Implements
ExtendedValidatorKeyStoreutilizingValidatorHASigner.Updated interfaces to return
nullwhen the signature isn't acquired & updated handling of signing fornullresults.Also some cleanup on previous HA work like consolidating config