Harden telemetry advice fail-open behavior#10
Open
ConanScott wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pjp.proceed()behaviorValidation
Tested on an APIM EC2 host after building the assembled install set with:
With the complete runtime jar set copied into
apigateway/ext/lib, Gateway started, ANM login worked, traffic flowed normally, expected OpenTelemetry logging was present, and no errors were logged.Then
opentelemetry-instrumentation-api-2.18.1.jarwas moved aside and APIM was restarted. Gateway still started, ANM login worked, and traffic flowed without errors. Telemetry was not recorded in that broken-dependency case, which is the intended fail-open behavior.Notes
This is a customer-safety hardening change: telemetry should be best-effort and must not turn dependency/setup failures into API Gateway request failures.