Split CBOR encoder to support Jackson 2 and 3#134
Open
Conversation
alex-w0
changed the title
...nt/src/main/java/io/axoniq/console/framework/client/strategy/CborJackson3EncodingStrategy.kt
Outdated
Show resolved
Hide resolved
...nt/src/main/java/io/axoniq/console/framework/client/strategy/CborJackson2EncodingStrategy.kt
Outdated
Show resolved
Hide resolved
...ramework-client/src/main/java/io/axoniq/console/framework/AxoniqConsoleConfigurerModule.java
Show resolved
Hide resolved
CodeDrivenMitch
requested changes
Apr 7, 2026
Collaborator
CodeDrivenMitch
left a comment
CodeDrivenMitch
left a comment
There was a problem hiding this comment.
We need to downgrade the Kotlin version, and update the copyright headers. Hence not approving yet.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the CBOR encoder to provide separate support for Jackson 2 and Jackson 3, with the goal of supporting Spring Boot 4.